Is it a bug if the LCOV parser blows up when the number of hits exceed Java's 32 bit signed int?

[mikelupo]

java.lang.NumberFormatException: For input string: "2874063630"
at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:67)
at java.base/java.lang.Integer.parseInt(Integer.java:662)
at java.base/java.lang.Integer.parseInt(Integer.java:778)
at PluginClassLoader for coverage//edu.hm.hafner.coverage.parser.LcovParser.parseReport(LcovParser.java:78)

As a workaround, I have to take the info file and normalize it. I set the number of hits to 1 unless they were already 0.

normalize_lcov_hits_for_jenkins() {
    local input_file="$1"
    local output_file="$2"

    awk '
        /^DA:/ {
            split($0, fields, ",")
            count = fields[2]

            if (count ~ /^[0-9]+$/ && count > 0) {
                fields[2] = 1
            }

            print fields[1] "," fields[2]
            next
        }

        /^BRDA:/ {
            n = split($0, fields, ",")

            if (n >= 4 && fields[4] ~ /^[0-9]+$/ && fields[4] > 0) {
                fields[4] = 1
            }

            out = fields[1]
            for (i = 2; i <= n; i++) {
                out = out "," fields[i]
            }

            print out
            next
        }

        {
            print
        }
    ' "${input_file}" > "${output_file}"
}

[henry2cox]

No. Not expected.
But it also looks like your stack trace is from your Java infrastructure - not from anything directly related to lcov.

Do you have a testcase which illustrates the issue?

[mikelupo]

I could give you the .info file, but need to scrub it first. I have more call stack as well that I could provide. Again, needs scrubbing perhaps. The Cobertura parser handles the high number of hits. Maybe they use long int instead of int. Anyway, I will work towards a scrubbed .info file and will follow up with a reply.

[mikelupo]

I didn't need to scrub anything. I was able to craft a small example of what would cause the LCOV parser to fail in Jenkins.
I put this in a file called, "coverage.intfail.info

TN:int-parse-fail-demo
SF:/tmp/jenkins-lcov-int-fail-demo.c
FN:1,main
FNDA:2874063630,main
FNF:1
FNH:1
DA:1,2874063630
DA:2,1
LF:2
LH:2
BRDA:1,0,0,2874063630
BRF:1
BRH:1
end_of_record

How it's used in Jenkins...

recordCoverage(
            name: "INT FAIL",
            checksName: 'int fail bug',
            tools: [[parser: 'LCOV', pattern: 'coverage.intfail.info']],
            sourceCodeRetention: 'EVERY_BUILD',
            sourceDirectories: [[path: 'COMPONENT_SOURCE/Path/FooProject']],
            enabledForFailure: true
        )

Full call stack....

java.lang.NumberFormatException: For input string: "2874063630"
	at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:67)
	at java.base/java.lang.Integer.parseInt(Integer.java:662)
	at java.base/java.lang.Integer.parseInt(Integer.java:778)
	at PluginClassLoader for coverage//edu.hm.hafner.coverage.parser.LcovParser.parseReport(LcovParser.java:78)
Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to prod-scripts-app11.bos01.corp.akamai.com
		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1916)
		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:384)
		at hudson.remoting.Channel.call(Channel.java:1108)
		at hudson.FilePath.act(FilePath.java:1217)
		at hudson.FilePath.act(FilePath.java:1206)
		at PluginClassLoader for coverage//io.jenkins.plugins.coverage.metrics.steps.CoverageRecorder.recordCoverageResults(CoverageRecorder.java:498)
		at PluginClassLoader for coverage//io.jenkins.plugins.coverage.metrics.steps.CoverageRecorder.perform(CoverageRecorder.java:418)
		at PluginClassLoader for coverage//io.jenkins.plugins.coverage.metrics.steps.CoverageRecorder.perform(CoverageRecorder.java:408)
		at PluginClassLoader for coverage//io.jenkins.plugins.coverage.metrics.steps.CoverageStep$Execution.run(CoverageStep.java:369)
		at PluginClassLoader for coverage//io.jenkins.plugins.coverage.metrics.steps.CoverageStep$Execution.run(CoverageStep.java:337)
		at PluginClassLoader for workflow-step-api//org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:49)
		at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:572)
		at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
		at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
		at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
		at java.base/java.lang.Thread.run(Thread.java:1583)
Also:   org.jenkinsci.plugins.workflow.actions.ErrorAction$ErrorId: 592161d1-81c0-4fe6-9bee-0f4528f1efca

[henry2cox]

$ ./bin/lcov -a count.info --branch
Combining tracefiles.
.. found 1 files to aggregate.
Reading tracefile count.info.
lcov: WARNING: (format) invalid characters removed from testname in tracefile count.info: 'int-parse-fail-demo'->'int_parse_fail_demo'
        (use "lcov --ignore-errors format,format ..." to suppress this warning)
lcov: WARNING: (unsupported) Function begin/end line exclusions not supported with this version of GCC/gcov; require gcc/9 or newer: attempting to derive function end lines - see lcovrc man entry for 'derive_function_end_line'.
        (use "lcov --ignore-errors unsupported,unsupported ..." to suppress this warning)
TN:int_parse_fail_demo
SF:/tmp/jenkins-lcov-int-fail-demo.c
FNL:0,1,2
FNA:0,2874063630,main
FNF:1
FNH:1
BRDA:1,0,0,2874063630
BRF:1
BRH:1
DA:1,2874063630
DA:2,1
LF:2
LH:2
end_of_record
Summary coverage rate:
  source files: 1
  lines.......: 100.0% (2 of 2 lines)
  functions...: 100.0% (1 of 1 function)
  branches....: 100.0% (1 of 1 branch)
Message summary:
  2 warning messages:
    format: 1
    unsupported: 1

I don't see the error you see - and the warnings are self explanatory and innocuous.

What version of lcov are you using?
Are you sure that the message you are getting is coming from lcov and not from elsewhere in your infrastructure?

update: actually: looking at your stacktrace, the message seems to be coming from LcovParser.java:78) - which is not part of lcov.

[mikelupo]

my version of lcov is 1.14, but I think the Jenkins plugin isn't using that, per-se.
This is where I think the bug is. So it's a java app that's ingesting the native lcov generated stuff and then trying to read/parse
the .info file.
https://github.com/jenkinsci/coverage-model/blob/ccd814683eab9438d71085f945d7f4427a1c0c9b/src/main/java/edu/hm/hafner/coverage/parser/LcovParser.java#L78-L79

@henry2cox thank you for this discussion. I appreciate you looking into this as quickly as you did!
I hope I wasn't too annoying.
--Mike