Skip to content

Commit 7794cf2

Browse files
committed
Add documentation about Dasharo toolchain compatibility
Document why Dasharo forks cannot share toolchains with upstream coreboot: - Dasharo uses custom FSP packages with different/incompatible headers - Changes have not been upstreamed to coreboot yet - Each Dasharo fork must build its own crossgcc toolchain Also cleaned up modules/coreboot comments and CircleCI config comments.
1 parent c625b77 commit 7794cf2

2 files changed

Lines changed: 14 additions & 2 deletions

File tree

.circleci/config.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -261,8 +261,10 @@ workflows:
261261
requires:
262262
- x86-musl-cross-make
263263

264-
# Dasharo forks each build their own crossgcc toolchain from the Dasharo coreboot fork.
265-
# They cannot reuse upstream toolchains due to FSP header compatibility issues.
264+
# Dasharo forks - each builds its own crossgcc toolchain
265+
# IMPORTANT: Dasharo boards CANNOT share toolchains with upstream coreboot releases
266+
# because their custom FSP headers are incompatible with upstream FSP packages.
267+
# See modules/coreboot for details.
266268

267269
# Dasharo v56 (V540TU/V560TU) - builds its own toolchain
268270
- build_and_persist:

modules/coreboot

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,16 @@ $(eval $(call coreboot_module,purism,24.02.01))
101101

102102
# Dasharo forks - based on various coreboot upstream releases
103103
# All include 3rdparty/intel-microcode 20251111
104+
#
105+
# IMPORTANT: Dasharo forks CANNOT share toolchains with upstream coreboot releases
106+
# or with each other. This is because:
107+
# 1. Dasharo uses custom FSP packages (3rdparty/dasharo-blobs/) that have different
108+
# headers than upstream FSP packages (3rdparty/fsp/)
109+
# 2. Dasharo's FSP packages are missing headers (MemInfoHob.h) that their coreboot
110+
# fork code includes, and have different headers (FirmwareVersionInfo.h vs
111+
# FirmwareVersionInfoHob.h)
112+
# 3. These changes have not been upstreamed to coreboot yet
113+
# Therefore, each Dasharo fork builds its own crossgcc toolchain (empty second arg)
104114

105115
# NovaCustom V560TU/V540TU (Meteor Lake)
106116
# Tag: novacustom_v56x_mtl_igpu_v1.0.1 (SHA: 6de027d1)

0 commit comments

Comments
 (0)