Revert: Dasharo forks build their own toolchain

Dasharo boards cannot share toolchains with upstream coreboot releases
or each other due to FSP header compatibility issues:
- Dasharo's custom FSP packages (in 3rdparty/dasharo-blobs/) are missing
  headers that their coreboot fork code expects (MemInfoHob.h, etc)
- Upstream FSP packages have different headers that Dasharo's code
  includes (FirmwareVersionInfoHob.h vs FirmwareVersionInfo.h)

This reverts the toolchain sharing optimization and returns to having
each Dasharo fork build its own crossgcc toolchain.

Removed coreboot-24.12 and coreboot-25.03 from cache (only needed if
Dasharo forks could share toolchains, which they can't).

Author: tlaurion

.circleci/config.yml

@@ -204,10 +204,8 @@ jobs:
             - build/x86/coreboot-4.20.1
             - build/x86/coreboot-4.22.01
             - build/x86/coreboot-24.02.01
-            - build/x86/coreboot-24.12
-            - build/x86/coreboot-25.03
             - build/x86/coreboot-25.09
-            # Dasharo forks (coreboot git checkouts, not releases)
+            # Dasharo forks (each builds its own toolchain from the Dasharo coreboot fork)
             - build/x86/coreboot-dasharo_v56
             - build/x86/coreboot-dasharo_nv4x
             - build/x86/coreboot-dasharo_msi_z790
@@ -263,18 +261,21 @@ workflows:
           requires:
             - x86-musl-cross-make
 
-      # Toolchain: 24.12 (used by dasharo_nv4x, dasharo_msi_z690, dasharo_msi_z790)
+      # Dasharo forks each build their own crossgcc toolchain from the Dasharo coreboot fork.
+      # They cannot reuse upstream toolchains due to FSP header compatibility issues.
+
+      # Dasharo v56 (V540TU/V560TU) - builds its own toolchain
       - build_and_persist:
-          name: novacustom-nv4x_adl
-          target: novacustom-nv4x_adl
+          name: novacustom-v560tu
+          target: novacustom-v560tu
           subcommand: ""
           requires:
             - x86-musl-cross-make
 
-      # Toolchain: 25.03 (used by dasharo_v56)
+      # Dasharo nv4x (NV4x ADL/NS50) - builds its own toolchain
       - build_and_persist:
-          name: novacustom-v560tu
-          target: novacustom-v560tu
+          name: novacustom-nv4x_adl
+          target: novacustom-nv4x_adl
           subcommand: ""
           requires:
             - x86-musl-cross-make
@@ -582,19 +583,28 @@ workflows:
             - EOL_t480-hotp-maximized
 
       #----------------------------------------
-      # Toolchain 24.12 (dasharo_nv4x, dasharo_msi_z690, dasharo_msi_z790)
+      # Dasharo forks - each builds its own toolchain
       #----------------------------------------
-      # These boards share the 24.12 toolchain from novacustom-nv4x_adl
+      # Note: Dasharo boards cannot share toolchains with upstream coreboot releases
+      # because their custom FSP headers are incompatible with upstream FSP packages.
+
+      # dasharo_v56: V560TU builds its own toolchain, V540TU depends on it
+      - build:
+          name: novacustom-v540tu
+          target: novacustom-v540tu
+          subcommand: ""
+          requires:
+            - novacustom-v560tu
 
-      # dasharo_nv4x: NV4x ADL / NS50
+      # dasharo_nv4x: NV4x ADL builds its own toolchain
       - build:
           name: UNTESTED_nitropad-ns50
           target: UNTESTED_nitropad-ns50
           subcommand: ""
           requires:
             - novacustom-nv4x_adl
 
-      # dasharo_msi_z690: MSI Z690 boards
+      # dasharo_msi_z690: builds on nv4x toolchain (both based on same Dasharo fork)
       - build:
           name: UNTESTED_msi_z690a_ddr4
           target: UNTESTED_msi_z690a_ddr4
@@ -609,7 +619,7 @@ workflows:
           requires:
             - UNTESTED_msi_z690a_ddr4
 
-      # dasharo_msi_z790: MSI Z790 boards
+      # dasharo_msi_z790: builds on nv4x toolchain (both based on same Dasharo fork)
       - build:
           name: UNTESTED_msi_z790p_ddr4
           target: UNTESTED_msi_z790p_ddr4
@@ -623,15 +633,3 @@ workflows:
           subcommand: ""
           requires:
             - UNTESTED_msi_z790p_ddr4
-
-      #----------------------------------------
-      # Toolchain 25.03 (dasharo_v56)
-      #----------------------------------------
-      # These boards share the 25.03 toolchain from novacustom-v560tu
-
-      - build:
-          name: novacustom-v540tu
-          target: novacustom-v540tu
-          subcommand: ""
-          requires:
-            - novacustom-v560tu

modules/coreboot

@@ -104,33 +104,33 @@ $(eval $(call coreboot_module,purism,24.02.01))
 
 # NovaCustom V560TU/V540TU (Meteor Lake)
 #  Tag: novacustom_v56x_mtl_igpu_v1.0.1 (SHA: 6de027d1)
-#  Based on coreboot 25.03, uses 25.03 toolchain
+#  Based on coreboot 25.03
 coreboot-dasharo_v56_repo := https://github.com/dasharo/coreboot
 coreboot-dasharo_v56_commit_hash := 6de027d1f0a62753182237ce3d793e5ba0395139
-$(eval $(call coreboot_module,dasharo_v56,25.03))
+$(eval $(call coreboot_module,dasharo_v56,))
 coreboot-dasharo_v56_patch_version := unreleased
 
 # NovaCustom NV4x ADL / NS50
 #  Tag: novacustom_nv4x_adl_v1.8.0 (SHA: 281a7fec)
-#  Based on coreboot 24.12, uses 24.12 toolchain
+#  Based on coreboot 24.12
 coreboot-dasharo_nv4x_repo := https://github.com/dasharo/coreboot
 coreboot-dasharo_nv4x_commit_hash := 281a7fec1a1e7aed781b12a096c2fc0f87dc51b5
-$(eval $(call coreboot_module,dasharo_nv4x,24.12))
+$(eval $(call coreboot_module,dasharo_nv4x,))
 #coreboot-dasharo_nv4x_patch_version := unreleased
 
 # MSI Z790 boards
 #  Tag: msi_ms7e06_v0.9.4 (SHA: a5a05f13)
-#  Based on coreboot 24.12, uses 24.12 toolchain
+#  Based on coreboot 24.12
 coreboot-dasharo_msi_z790_repo := https://github.com/dasharo/coreboot
 coreboot-dasharo_msi_z790_commit_hash := a5a05f133471c0463609631b599cdd88a623561f
-$(eval $(call coreboot_module,dasharo_msi_z790,24.12))
+$(eval $(call coreboot_module,dasharo_msi_z790,))
 
 # MSI Z690 boards
 #  Tag: msi_ms7d25_v1.1.6 (SHA: be7d58da)
-#  Based on coreboot 24.12, uses 24.12 toolchain
+#  Based on coreboot 24.12
 coreboot-dasharo_msi_z690_repo := https://github.com/dasharo/coreboot
 coreboot-dasharo_msi_z690_commit_hash := be7d58dac9365d8981dbb1f5c6bbbcce35df8636
-$(eval $(call coreboot_module,dasharo_msi_z690,24.12))
+$(eval $(call coreboot_module,dasharo_msi_z690,))
 
 # T480 is based on coreboot ~25.09 release
 #  coreboot 25.09 doesn't include Thunderbolt support and support of the lower USB-C port which is still under review at https://review.coreboot.org/c/coreboot/+/75286 and https://review.coreboot.org/c/coreboot/+/88490