Fix MTL coreboot configs per PR #2082 review feedback

- Re-enable CONFIG_DASHARO_FIRMWARE_UPDATE_MODE=y (was incorrectly disabled)
- Enable CONFIG_DRIVERS_GENERIC_CBFS_SERIAL=y (required for Dasharo)
- Re-enable CONFIG_USE_PC_CMOS_ALTCENTURY=y (reverted broken commit)
- Disable bootsplash (CONFIG_BOOTSPLASH=n, CONFIG_BOOTSPLASH_IMAGE=n)
- Remove unused @COREBOOT_BUILD_DIR@ sed replacement in modules/coreboot

Author: tlaurion

config/coreboot-novacustom-v540tu.config

@@ -34,7 +34,7 @@ CONFIG_HAVE_ASAN_IN_RAMSTAGE=y
 # CONFIG_NO_STAGE_CACHE is not set
 CONFIG_TSEG_STAGE_CACHE=y
 # CONFIG_UPDATE_IMAGE is not set
-CONFIG_BOOTSPLASH_IMAGE=y
+# CONFIG_BOOTSPLASH_IMAGE is not set
 CONFIG_BOOTSPLASH_FILE="@BRAND_DIR@/bootsplash.jpg"
 CONFIG_BOOTSPLASH_REGION_LOGO_FILE=""
 CONFIG_BOOTSPLASH_CONVERT=y
@@ -584,7 +584,7 @@ CONFIG_BIOS_VENDOR="3mdeb"
 # Dasharo Configuration
 #
 CONFIG_DASHARO_PREFER_S3_SLEEP=y
-# CONFIG_DASHARO_FIRMWARE_UPDATE_MODE is not set
+CONFIG_DASHARO_FIRMWARE_UPDATE_MODE=y
 # end of Dasharo Configuration
 
 CONFIG_ACPI_FNKEY_GEN_SCANCODE=0
@@ -643,7 +643,7 @@ CONFIG_NO_EARLY_GFX_INIT=y
 #
 CONFIG_GENERIC_LINEAR_FRAMEBUFFER=y
 CONFIG_LINEAR_FRAMEBUFFER=y
-CONFIG_BOOTSPLASH=y
+# CONFIG_BOOTSPLASH is not set
 CONFIG_DEFAULT_SCREEN_ROTATION_INT=0
 # end of Display
 
@@ -692,7 +692,7 @@ CONFIG_DRIVERS_UART_8250MEM=y
 CONFIG_DRIVERS_UART_8250MEM_32=y
 # CONFIG_VPD is not set
 CONFIG_DRIVERS_GENERIC_BAYHUB_LV2=y
-# CONFIG_DRIVERS_GENERIC_CBFS_SERIAL is not set
+CONFIG_DRIVERS_GENERIC_CBFS_SERIAL=y
 # CONFIG_DRIVERS_GENERIC_CBFS_UUID is not set
 # CONFIG_DRIVERS_GENESYSLOGIC_GL9750 is not set
 # CONFIG_DRIVERS_GENESYSLOGIC_GL9755 is not set
@@ -739,7 +739,7 @@ CONFIG_INTEL_GMA_VERSION_2=y
 CONFIG_DRIVERS_INTEL_PMC=y
 # CONFIG_DRIVERS_NXP_UWB_SR1XX is not set
 CONFIG_DRIVERS_MC146818=y
-# CONFIG_USE_PC_CMOS_ALTCENTURY is not set
+CONFIG_USE_PC_CMOS_ALTCENTURY=y
 CONFIG_PC_CMOS_BASE_PORT_BANK0=0x70
 CONFIG_MEMORY_MAPPED_TPM=y
 CONFIG_TPM_TIS_BASE_ADDRESS=0xfed40000

config/coreboot-novacustom-v560tu.config

@@ -34,7 +34,7 @@ CONFIG_HAVE_ASAN_IN_RAMSTAGE=y
 # CONFIG_NO_STAGE_CACHE is not set
 CONFIG_TSEG_STAGE_CACHE=y
 # CONFIG_UPDATE_IMAGE is not set
-CONFIG_BOOTSPLASH_IMAGE=y
+# CONFIG_BOOTSPLASH_IMAGE is not set
 CONFIG_BOOTSPLASH_FILE="@BRAND_DIR@/bootsplash.jpg"
 CONFIG_BOOTSPLASH_REGION_LOGO_FILE=""
 CONFIG_BOOTSPLASH_CONVERT=y
@@ -584,7 +584,7 @@ CONFIG_BIOS_VENDOR="3mdeb"
 # Dasharo Configuration
 #
 CONFIG_DASHARO_PREFER_S3_SLEEP=y
-# CONFIG_DASHARO_FIRMWARE_UPDATE_MODE is not set
+CONFIG_DASHARO_FIRMWARE_UPDATE_MODE=y
 # end of Dasharo Configuration
 
 CONFIG_ACPI_FNKEY_GEN_SCANCODE=0
@@ -643,7 +643,7 @@ CONFIG_NO_EARLY_GFX_INIT=y
 #
 CONFIG_GENERIC_LINEAR_FRAMEBUFFER=y
 CONFIG_LINEAR_FRAMEBUFFER=y
-CONFIG_BOOTSPLASH=y
+# CONFIG_BOOTSPLASH is not set
 CONFIG_DEFAULT_SCREEN_ROTATION_INT=0
 # end of Display
 
@@ -692,7 +692,7 @@ CONFIG_DRIVERS_UART_8250MEM=y
 CONFIG_DRIVERS_UART_8250MEM_32=y
 # CONFIG_VPD is not set
 CONFIG_DRIVERS_GENERIC_BAYHUB_LV2=y
-# CONFIG_DRIVERS_GENERIC_CBFS_SERIAL is not set
+CONFIG_DRIVERS_GENERIC_CBFS_SERIAL=y
 # CONFIG_DRIVERS_GENERIC_CBFS_UUID is not set
 # CONFIG_DRIVERS_GENESYSLOGIC_GL9750 is not set
 # CONFIG_DRIVERS_GENESYSLOGIC_GL9755 is not set
@@ -739,7 +739,7 @@ CONFIG_INTEL_GMA_VERSION_2=y
 CONFIG_DRIVERS_INTEL_PMC=y
 # CONFIG_DRIVERS_NXP_UWB_SR1XX is not set
 CONFIG_DRIVERS_MC146818=y
-# CONFIG_USE_PC_CMOS_ALTCENTURY is not set
+CONFIG_USE_PC_CMOS_ALTCENTURY=y
 CONFIG_PC_CMOS_BASE_PORT_BANK0=0x70
 CONFIG_MEMORY_MAPPED_TPM=y
 CONFIG_TPM_TIS_BASE_ADDRESS=0xfed40000

modules/coreboot

@@ -199,7 +199,6 @@ $(coreboot_module)_configure := \
 		sed -i '/^CONFIG_MAINBOARD_SMBIOS_MANUFACTURER/d' $(build)/$(coreboot_dir)/.config; \
 		echo 'CONFIG_MAINBOARD_SMBIOS_MANUFACTURER="$(CONFIG_COREBOOT_SMBIOS_MANUFACTURER)"' >> $(build)/$(coreboot_dir)/.config; \
 	fi; \
-	sed -i 's|@COREBOOT_BUILD_DIR@|$(build)/$(coreboot_dir)|g' "$(build)/$(coreboot_dir)/.config"; \
 	$(MAKE) olddefconfig \
 		-C "$(build)/$(coreboot_base_dir)" \
 		obj="$(build)/$(coreboot_dir)" \