Skip to content

Commit f6a4e38

Browse files
committed
modules/coreboot: rebuild ROM on inputs, not phony
Prior PR marked the ROM target phony to force rebuilds. The new CBFS/IFD validation already runs after the coreboot build and downstream post-processing is guarded by up-to-date checks, so letting make track the actual output avoids unnecessary rebuilds while keeping validation intact. Signed-off-by: Thierry Laurion <insurgo@riseup.net>
1 parent 9679449 commit f6a4e38

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

modules/coreboot

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -269,9 +269,8 @@ $(build)/$(coreboot_dir)/.build: \
269269
# This produces a ROM image that is written with the flashrom program
270270
ifneq ($(CONFIG_COREBOOT),)
271271

272-
# Keep this phony so the ROM is rebuilt each time; downstream logic
272+
# Let make rebuild the ROM only when inputs change; downstream logic
273273
# will ensure expensive post-processing (like GPG injection) is skipped when up-to-date.
274-
.PHONY: $(build)/$(BOARD)/$(CB_OUTPUT_FILE)
275274
$(build)/$(BOARD)/$(CB_OUTPUT_FILE): $(build)/$(coreboot_dir)/.build
276275
# Use coreboot.rom, because custom output files might not be processed by cbfstool
277276
"$(build)/$(coreboot_dir)/cbfstool" "$(dir $<)coreboot.rom" print

0 commit comments

Comments
 (0)