Skip to content

fix: add X-Deepin-Singleton flag to desktop file (#392841)#337

Open
add-uos wants to merge 1 commit into
linuxdeepin:masterfrom
add-uos:task-392841-add-x-deepin-singleton-flag
Open

fix: add X-Deepin-Singleton flag to desktop file (#392841)#337
add-uos wants to merge 1 commit into
linuxdeepin:masterfrom
add-uos:task-392841-add-x-deepin-singleton-flag

Conversation

@add-uos

@add-uos add-uos commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Add X-Deepin-Singleton=true to desktop file to mark the application as a singleton app. This allows AM to identify singleton apps and inform Treeland to skip the splash screen for these apps.

Refs: https://pms.uniontech.com/task-view-392841.html

Summary by Sourcery

New Features:

  • Mark the calendar application as a singleton via the X-Deepin-Singleton flag in its desktop file to support specialized handling by the application manager and window system.

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai

sourcery-ai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds the X-Deepin-Singleton flag to the dde-calendar desktop entry to mark the calendar application as a singleton so Application Manager can skip the splash screen for it.

File-Level Changes

Change Details Files
Mark the dde-calendar application as a singleton via its desktop file so upstream components can skip the splash screen.
  • Add X-Deepin-Singleton=true key to the desktop entry to indicate singleton behavior
  • Ensure the desktop file metadata aligns with Deepin/AM expectations for identifying singleton apps
src/calendar-client/assets/dde-calendar.desktop

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

★ 总体评分:100分

■ 【总体评价】

代码为日历应用添加了单例运行模式配置,整体质量优秀。
修改逻辑正确,无安全风险,符合配置文件规范。

■ 【详细分析】

  • 1.语法逻辑(基本正确)✓

dde-calendar.desktop 文件中新增了 X-Deepin-Singleton=true 配置项,语法符合 desktop 文件规范。
潜在问题:无
建议:无需修改

  • 2.代码质量(符合规范)✓

新增的配置项位于 X-Deepin-Vendor 下方,格式对齐,符合规范。
潜在问题:无
建议:无需修改

  • 3.代码性能(无性能问题)✓

启用单例模式可以防止用户多次启动日历应用导致资源浪费,有助于提升系统资源利用率。
潜在问题:无
建议:无需修改

  • 4.代码安全(存在0个安全漏洞)✓

漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
本次修改仅为桌面配置文件增加单例属性,不涉及任何代码逻辑、外部输入处理或权限操作,无安全风险。

  • 建议:无需修改

■ 【改进建议代码示例】

diff --git a/src/calendar-client/assets/dde-calendar.desktop b/src/calendar-client/assets/dde-calendar.desktop
index c422b523..9de3cb15 100644
--- a/src/calendar-client/assets/dde-calendar.desktop
+++ b/src/calendar-client/assets/dde-calendar.desktop
@@ -11,6 +11,7 @@ Terminal=false
 Type=Application
 #X-Deepin-TurboType=dtkwidget
 X-Deepin-Vendor=deepin
+X-Deepin-Singleton=true
 X-MultipleArgs=false
 
 # Translations:

Add X-Deepin-Singleton=true to desktop file to mark the
application as a singleton app.

为单例应用的desktop文件添加X-Deepin-Singleton=true标识。

Log: 添加单例应用标识
PMS: TASK-392841
Influence: AM能识别单例应用,Treeland不再为单例应用显示快速启动画面
@add-uos
add-uos force-pushed the task-392841-add-x-deepin-singleton-flag branch from 4b8a115 to e833f34 Compare July 17, 2026 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants