Skip to content

fix: Update sidebar icon and polish UI layout#271

Merged
deepin-bot[bot] merged 1 commit into
linuxdeepin:develop/snipefrom
re2zero:bugfix
Sep 11, 2025
Merged

fix: Update sidebar icon and polish UI layout#271
deepin-bot[bot] merged 1 commit into
linuxdeepin:develop/snipefrom
re2zero:bugfix

Conversation

@re2zero
Copy link
Copy Markdown
Contributor

@re2zero re2zero commented Sep 11, 2025

  • Center “My Event” dialog title and widen its label
  • Ensure schedule-edit cancel button actually closes the dialog
  • Refresh Lao translation for “Life” event type

Log: Fix some UI issues.
Bug:
https://pms.uniontech.com/bug-view-332585.html
https://pms.uniontech.com/bug-view-332379.html
https://pms.uniontech.com/bug-view-332065.html
https://pms.uniontech.com/bug-view-332057.html

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @re2zero, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

-Center “My Event” dialog title and widen its label -Ensure
schedule-edit cancel button actually closes the dialog -Refresh Lao
translation for “Life” event type

Log: Fix some UI issues. Bug:
https://pms.uniontech.com/bug-view-332585.html
https://pms.uniontech.com/bug-view-332379.html
https://pms.uniontech.com/bug-view-332065.html
https://pms.uniontech.com/bug-view-332057.html
@deepin-ci-robot
Copy link
Copy Markdown

deepin pr auto review

根据提供的git diff,我将对代码进行审查,并提出改进建议:

SVG图标改进

  1. 尺寸变化

    • 图标尺寸从19x14px改为16x16px,这是一个更标准的图标尺寸,有利于保持界面一致性
    • 建议:保持统一使用16x16px的尺寸,确保图标在不同场景下的显示一致性
  2. 样式优化

    • 新的SVG图标采用了更现代的设计风格
    • 添加了fill-opacity属性,使图标具有更好的透明度控制
    • 建议:确保深色和浅色主题下的颜色对比度合适,保证可读性
  3. 结构优化

    • 图标的组织结构更加清晰,使用了多层编组
    • 建议:可以考虑进一步简化路径数据,减少文件大小

C++代码改进

  1. CTitleWidget改进

    • 添加了layout->addSpacing(10);增加了左侧间距,改善了布局
    • 建议:可以将间距值定义为常量,便于统一管理和修改
  2. MyScheduleView改进

    • 修复了日志格式化中的换行问题
    • 增加了close()调用,确保对话框正确关闭
    • 标题宽度从108px增加到220px,文本居中位置相应调整
    • 建议:
      • 考虑使用布局管理器来控制标题位置,而不是使用固定坐标
      • 将固定尺寸值定义为常量,提高代码可维护性
  3. 翻译改进

    • 修正了"ຊີວ຿ດຕິດ"为"ຊີວິດ"
    • 建议:建立翻译审查流程,避免此类拼写错误

总体建议

  1. 代码规范

    • 统一使用常量定义固定值(如尺寸、间距等)
    • 使用布局管理器代替绝对定位
    • 保持代码风格一致
  2. 性能优化

    • SVG图标可以考虑进一步压缩
    • 避免在UI代码中使用硬编码的魔法数字
  3. 可维护性

    • 将UI相关配置集中管理
    • 添加必要的注释说明关键逻辑
  4. 用户体验

    • 确保图标在不同主题下都有良好的视觉效果
    • 验证所有UI调整后的显示效果

这些改进将有助于提高代码质量、可维护性和用户体验。

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lzwind, re2zero

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@re2zero
Copy link
Copy Markdown
Contributor Author

re2zero commented Sep 11, 2025

/forcemerge

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Sep 11, 2025

This pr force merged! (status: unstable)

@deepin-bot deepin-bot Bot merged commit cba82c8 into linuxdeepin:develop/snipe Sep 11, 2025
20 of 21 checks passed
@re2zero re2zero deleted the bugfix branch September 11, 2025 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants