[dde-calendar] Updates for project Deepin Desktop Environment#316
Closed
transifex-integration[bot] wants to merge 105 commits into
Closed
[dde-calendar] Updates for project Deepin Desktop Environment#316transifex-integration[bot] wants to merge 105 commits into
transifex-integration[bot] wants to merge 105 commits into
Conversation
98% of minimum 50% translated source file: 'dde-calendar-service_en_US.ts' on 'ar'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
98% of minimum 50% translated source file: 'dde-calendar-service_en_US.ts' on 'ca'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: transifex-integration[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
98% of minimum 50% translated source file: 'dde-calendar-service_en_US.ts' on 'et'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
|
Hi @transifex-integration[bot]. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
69% of minimum 50% translated source file: 'dde-calendar-service_en_US.ts' on 'hr'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
67% of minimum 50% translated source file: 'dde-calendar-service_en_US.ts' on 'ka'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
Reviewer's GuideThis PR updates Qt TS translation files for Arabic and Catalan in dde-calendar, adjusting XML headers, fixing escaping for apostrophes, and revising numerous translation strings for wording, terminology, and status (including marking some as unfinished). File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
98% of minimum 50% translated source file: 'dde-calendar-service_en_US.ts' on 'fi'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
98% of minimum 50% translated source file: 'dde-calendar-service_en_US.ts' on 'nl'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
98% of minimum 50% translated source file: 'dde-calendar-service_en_US.ts' on 'pl'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
88% of minimum 50% translated source file: 'dde-calendar-service_en_US.ts' on 'sk'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
69% of minimum 50% translated source file: 'dde-calendar-service_en_US.ts' on 'en_AU'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
63% of minimum 50% translated source file: 'dde-calendar-service_en_US.ts' on 'th'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
69% of minimum 50% translated source file: 'dde-calendar-service_en_US.ts' on 'si'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 3 issues, and left some high level feedback:
- Several updated Estonian strings appear to degrade correctness or clarity (e.g. “Uus sündmus” → “Uus sujuv”, “Kalender on tööriist…” → “Kalender on tänavate vaatamise tööriist…”, and "%1 to %2" → "%1 %2"); please re‑review these with a native speaker and keep established calendar terminology where it was already accurate.
- Some parameterized strings and punctuation in the Estonian and Arabic translations were altered in ways that may break formatting or placeholders (e.g. translations for "(%1 mins)", "(%1 hour)", "(%1 hours)" missing closing parentheses or adding commas, and Arabic "%1 to %2" changing quoting style); align them closely with the source format to avoid runtime or UI issues.
- A few keys that previously had complete translations are now marked as
type="unfinished"(e.g. "import ICS file", "Please go to the Control Center to change system settings", "ICS File:" in multiple languages); confirm that this regression is intentional, or restore the prior translations if they were acceptable.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Several updated Estonian strings appear to degrade correctness or clarity (e.g. “Uus sündmus” → “Uus sujuv”, “Kalender on tööriist…” → “Kalender on tänavate vaatamise tööriist…”, and "%1 to %2" → "%1 %2"); please re‑review these with a native speaker and keep established calendar terminology where it was already accurate.
- Some parameterized strings and punctuation in the Estonian and Arabic translations were altered in ways that may break formatting or placeholders (e.g. translations for "(%1 mins)", "(%1 hour)", "(%1 hours)" missing closing parentheses or adding commas, and Arabic "%1 to %2" changing quoting style); align them closely with the source format to avoid runtime or UI issues.
- A few keys that previously had complete translations are now marked as `type="unfinished"` (e.g. "import ICS file", "Please go to the Control Center to change system settings", "ICS File:" in multiple languages); confirm that this regression is intentional, or restore the prior translations if they were acceptable.
## Individual Comments
### Comment 1
<location path="translations/dde-calendar-service_et.ts" line_range="286-289" />
<code_context>
<location filename="../calendar-client/src/dialog/scheduledlg.cpp" line="759"/>
<source>All Day:</source>
- <translation>Kogu päev:</translation>
+ <translation>Kokkuvõte:</translation>
</message>
<message>
</code_context>
<issue_to_address>
**issue (bug_risk):** "All Day" related strings were changed to "Kokkuvõte", which changes the meaning.
"Kokkuvõte" means "summary" in Estonian and does not represent an all‑day event, so this label will mislead users. Please keep using "Kogu päev" (or a close variant) for the "All Day" / "All Day:" strings.
</issue_to_address>
### Comment 2
<location path="translations/dde-calendar-service_et.ts" line_range="870" />
<code_context>
<location filename="../calendar-service/src/alarmManager/dalarmmanager.cpp" line="258"/>
<source>%1 to %2</source>
- <translation>'%1 kuni %2'</translation>
+ <translation>%1 %2</translation>
</message>
<message>
</code_context>
<issue_to_address>
**issue (bug_risk):** The "%1 to %2" template translation dropped the "to" meaning.
Here `%1 to %2` indicates a range (e.g. time or date). Changing it to `%1 %2` drops the equivalent of “kuni”/“–”, which loses that range meaning and can be ambiguous. Please keep an explicit range marker, e.g. `%1 kuni %2`.
</issue_to_address>
### Comment 3
<location path="translations/dde-calendar-service_ar.ts" line_range="270-271" />
<code_context>
<location filename="../calendar-client/src/dialog/scheduledlg.cpp" line="693"/>
<source>The name can not only contain whitespaces</source>
- <translation>لا يمكن أن يحتوي الاسم فقط على المسافات البيضاء</translation>
+ <translation>لا يمكن أن يتضمن الاسم سوى المسافات trắng</translation>
</message>
<message>
</code_context>
<issue_to_address>
**issue (typo):** Arabic translation accidentally includes a non‑Arabic word ("trắng").
`المسافات trắng` mixes Arabic with a Vietnamese word, which will appear obviously incorrect in the UI. Please use a fully Arabic wording, similar in meaning to the previous translation that referred to whitespace characters in Arabic only.
```suggestion
<source>The name can not only contain whitespaces</source>
+ <translation>لا يمكن أن يحتوي الاسم على مسافات بيضاء فقط</translation>
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+286
to
289
| <translation>Kokkuvõte:</translation> | ||
| </message> | ||
| <message> | ||
| <location filename="../calendar-client/src/dialog/scheduledlg.cpp" line="764"/> |
There was a problem hiding this comment.
issue (bug_risk): "All Day" related strings were changed to "Kokkuvõte", which changes the meaning.
"Kokkuvõte" means "summary" in Estonian and does not represent an all‑day event, so this label will mislead users. Please keep using "Kogu päev" (or a close variant) for the "All Day" / "All Day:" strings.
| <location filename="../calendar-service/src/alarmManager/dalarmmanager.cpp" line="258"/> | ||
| <source>%1 to %2</source> | ||
| <translation>'%1 kuni %2'</translation> | ||
| <translation>%1 %2</translation> |
There was a problem hiding this comment.
issue (bug_risk): The "%1 to %2" template translation dropped the "to" meaning.
Here %1 to %2 indicates a range (e.g. time or date). Changing it to %1 %2 drops the equivalent of “kuni”/“–”, which loses that range meaning and can be ambiguous. Please keep an explicit range marker, e.g. %1 kuni %2.
Comment on lines
270
to
+271
| <source>The name can not only contain whitespaces</source> | ||
| <translation>لا يمكن أن يحتوي الاسم فقط على المسافات البيضاء</translation> | ||
| <translation>لا يمكن أن يتضمن الاسم سوى المسافات trắng</translation> |
There was a problem hiding this comment.
issue (typo): Arabic translation accidentally includes a non‑Arabic word ("trắng").
المسافات trắng mixes Arabic with a Vietnamese word, which will appear obviously incorrect in the UI. Please use a fully Arabic wording, similar in meaning to the previous translation that referred to whitespace characters in Arabic only.
Suggested change
| <source>The name can not only contain whitespaces</source> | |
| <translation>لا يمكن أن يحتوي الاسم فقط على المسافات البيضاء</translation> | |
| <translation>لا يمكن أن يتضمن الاسم سوى المسافات trắng</translation> | |
| <source>The name can not only contain whitespaces</source> | |
| + <translation>لا يمكن أن يحتوي الاسم على مسافات بيضاء فقط</translation> |
98% of minimum 50% translated source file: 'dde-calendar-service_en_US.ts' on 'vi'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
99% of minimum 50% translated source file: 'dde-calendar_en_US.ts' on 'hu'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
63% of minimum 50% translated source file: 'dde-calendar_en_US.ts' on 'th'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
70% of minimum 50% translated source file: 'dde-calendar-service_en_US.ts' on 'da'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
98% of minimum 50% translated source file: 'dde-calendar_en_US.ts' on 'pt'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
96% of minimum 50% translated source file: 'dde-calendar_en_US.ts' on 'zh_HK'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
99% of minimum 50% translated source file: 'dde-calendar_en_US.ts' on 'fr'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
72% of minimum 50% translated source file: 'dde-calendar-service_en_US.ts' on 'ko'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
98% of minimum 50% translated source file: 'dde-calendar-service_en_US.ts' on 'zh_CN'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
98% of minimum 50% translated source file: 'dde-calendar-service_en_US.ts' on 'hu'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
87% of minimum 50% translated source file: 'dde-calendar_en_US.ts' on 'el'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
99% of minimum 50% translated source file: 'dde-calendar_en_US.ts' on 'pl'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
69% of minimum 50% translated source file: 'dde-calendar_en_US.ts' on 'si'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
87% of minimum 50% translated source file: 'dde-calendar-service_en_US.ts' on 'ja'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
97% of minimum 50% translated source file: 'dde-calendar-service_en_US.ts' on 'cs'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
96% of minimum 50% translated source file: 'dde-calendar_en_US.ts' on 'ug'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
99% of minimum 50% translated source file: 'dde-calendar_en_US.ts' on 'ro'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
98% of minimum 50% translated source file: 'dde-calendar-service_en_US.ts' on 'pt'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
99% of minimum 50% translated source file: 'dde-calendar_en_US.ts' on 'sq'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
72% of minimum 50% translated source file: 'dde-calendar-service_en_US.ts' on 'ms'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
67% of minimum 50% translated source file: 'dde-calendar_en_US.ts' on 'ka'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
98% of minimum 50% translated source file: 'dde-calendar-service_en_US.ts' on 'pt_BR'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
99% of minimum 50% translated source file: 'dde-calendar_en_US.ts' on 'ca'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
90% of minimum 50% translated source file: 'dde-calendar_en_US.ts' on 'ne'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
98% of minimum 50% translated source file: 'dde-calendar_en_US.ts' on 'ru'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
99% of minimum 50% translated source file: 'dde-calendar_en_US.ts' on 'uk'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
98% of minimum 50% translated source file: 'dde-calendar-service_en_US.ts' on 'lt'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
72% of minimum 50% translated source file: 'dde-calendar_en_US.ts' on 'ms'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
99% of minimum 50% translated source file: 'dde-calendar_en_US.ts' on 'az'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
58% of minimum 50% translated source file: 'dde-calendar_en_US.ts' on 'km_KH'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
98% of minimum 50% translated source file: 'dde-calendar-service_en_US.ts' on 'sl'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
100% translated source file: 'desktop.ts' on 'lo'.
88% of minimum 50% translated source file: 'dde-calendar_en_US.ts' on 'sk'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
99% of minimum 50% translated source file: 'dde-calendar_en_US.ts' on 'nl'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
98% of minimum 50% translated source file: 'dde-calendar-service_en_US.ts' on 'uk'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
98% of minimum 50% translated source file: 'dde-calendar-service_en_US.ts' on 'de_DE'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
58% of minimum 50% translated source file: 'dde-calendar-service_en_US.ts' on 'km_KH'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
73% of minimum 50% translated source file: 'dde-calendar_en_US.ts' on 'sr'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
98% of minimum 50% translated source file: 'dde-calendar-service_en_US.ts' on 'ro'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
99% of minimum 50% translated source file: 'dde-calendar_en_US.ts' on 'tr'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
63% of minimum 50% translated source file: 'dde-calendar_en_US.ts' on 'lv'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following localization files have been updated:
Details
Files