Skip to content

chore: Update version to 6.5.39#326

Merged
lzwind merged 1 commit into
linuxdeepin:masterfrom
add-uos:master
Apr 23, 2026
Merged

chore: Update version to 6.5.39#326
lzwind merged 1 commit into
linuxdeepin:masterfrom
add-uos:master

Conversation

@add-uos

@add-uos add-uos commented Apr 23, 2026

Copy link
Copy Markdown
Contributor
  • update version to 6.5.39

log: update version to 6.5.39

Summary by Sourcery

Build:

  • Update linglong packaging manifest to version 6.5.39.1.

- update version to 6.5.39

log: update version to 6.5.39
@github-actions

Copy link
Copy Markdown

TAG Bot

TAG: 6.5.39
EXISTED: no
DISTRIBUTION: unstable

@sourcery-ai

sourcery-ai Bot commented Apr 23, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Bumps the application/package version from 6.5.38.1 to 6.5.39.1 and aligns packaging metadata accordingly.

File-Level Changes

Change Details Files
Update application/package version metadata to 6.5.39.1.
  • Change the package version field from 6.5.38.1 to 6.5.39.1 in the main configuration manifest.
  • Ensure Debian packaging changelog is present/updated for the new version entry (verify actual content in the diff or repository).
linglong.yaml
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

这段代码变更主要涉及版本号的更新和 changelog 的记录。以下是详细的审查意见:

1. 语法逻辑审查

  • 版本号一致性
    • debian/changelog 中版本号更新为 6.5.39
    • linglong.yaml 中版本号更新为 6.5.39.1
    • 问题:这两个版本号格式不一致。Debian 包版本通常遵循 upstream_version-debian_revision 的格式,而 Linglong(玲珑)打包格式通常使用 major.minor.patchmajor.minor.patch.build
    • 建议:请确认项目的版本管理策略。通常 linglong.yaml 中的版本应该与源码版本(即 changelog 中的上游版本)保持一致,或者有明确的对应关系。如果 6.5.39 是源码版本,那么 linglong.yaml 中是否应该也是 6.5.39.1 后缀通常用于表示打包版本号(修订号)的迭代。如果这次更新仅仅是源码版本的升级,建议将 linglong.yaml 中的版本号改为 6.5.39;如果这是针对 6.5.39 源码的第一次打包尝试,保留 .1 是合理的,但需确保团队内部对版本号规范达成一致。

2. 代码质量审查

  • Changelog 规范
    • debian/changelog 的格式符合 Debian 标准规范,包含了包名、版本、发行版、紧急程度以及维护者信息和日期。
    • 提交信息使用了 chorei18nfix 等前缀,符合 Conventional Commits 规范,便于阅读和自动化工具解析。
    • 问题:日期显示为 2026 年(Thu, 23 Apr 2026)。
    • 建议:这看起来是一个明显的拼写错误,请检查系统时间或构建环境的时间设置,将其修正为当前年份(如 2024 或 2025)。错误的年份可能会导致包管理系统(如 APT)认为这是一个未来的包,从而影响依赖解析或升级逻辑。

3. 代码性能审查

  • 本次变更主要是元数据和文档(翻译、日志)的更新,不涉及具体的执行代码逻辑,因此对运行时性能没有直接影响。

4. 代码安全审查

  • 日期异常
    • 如前所述,2026 年的日期虽然不直接构成代码漏洞,但在某些构建系统中,异常的未来时间戳可能会干扰构建缓存、签名验证或日志审计,属于潜在的非功能性风险。
  • 翻译文件
    • 变更中提到了对 .ts(Qt 翻译源文件)的更新。虽然 diff 中没有展示具体内容,但需注意:
    • 建议:确保引入的外部翻译文件(特别是 fi 芬兰语和 pt_BR 葡萄牙语巴西)经过审核,防止通过翻译文件注入恶意字符串(例如格式化字符串攻击)。

总结与改进建议

  1. 修正日期:请将 debian/changelog 中的日期从 2026 年修正为当前实际年份。
  2. 统一版本号策略:明确 debian/changeloglinglong.yaml 中版本号的关系。如果 linglong.yaml 是用于打包容器,通常建议其 version 字段直接反映上游版本号(即 6.5.39),除非有特定的构建版本号需求。如果必须保留 .1,请确保在文档中说明该后缀的含义。
  3. 翻译审查:确认新增的翻译内容准确无误且无安全风险。

修正后的示例(仅针对日期和版本号一致性):

--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,13 @@
+dde-calendar (6.5.39) unstable; urgency=medium
+
+  * chore: Update version to 6.5.39
+  * i18n: Translate dde-calendar-service_en_US.ts in fi
+  * i18n: Translate dde-calendar_en_US.ts in pt_BR
+  * i18n: Translate dde-calendar-service_en_US.ts in pt_BR
+  * fix(dbus): add backend fallback for schedule CRUD operations
+
+ -- zhanghongyuan <zhanghongyuan@uniontech.com>  Thu, 23 Apr 2024 17:25:57 +0800
+
 dde-calendar (6.5.38) unstable; urgency=medium
 
   * fix: resolve high CPU usage and account loading failures
diff --git a/linglong.yaml b/linglong.yaml
index 784513f0..b574788c 100644
--- a/linglong.yaml
+++ b/linglong.yaml
@@ -7,7 +7,7 @@ version: "1"
 package:
   id: org.dde.calendar
   name: dde-calendar
-  version: 6.5.38.1
+  version: 6.5.39
   kind: app
   description: |
     calendar for deepin os.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lzwind lzwind merged commit bdf80b6 into linuxdeepin:master Apr 23, 2026
23 checks passed
@deepin-bot

deepin-bot Bot commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

TAG Bot

Tag created successfully

📋 Tag Details
  • Tag Name: 6.5.39
  • Tag SHA: 59c5d8fc0cf16e1b45850475f2b351f32696b5fd
  • Commit SHA: 4149ea4a6d2afe0522f49b9e7f6f82e9e54c9d79
  • Tag Message:
    Release dde-calendar 6.5.39
    
    
  • Tagger:
    • Name: add-uos
  • Distribution: unstable

@deepin-bot deepin-bot Bot mentioned this pull request Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants