fix: defer DSysInfo queries in plugins to avoid dlopen deadlock

yixinshark · yixinshark · commit 3165c9bed16f · 2026-07-09T10:41:02.000+08:00
The control center loads plugins via QPluginLoader during startup. Several
plugins called DSysInfo::uosType()/uosEditionType()/deepinType()/isDeepin()
in global/static initialization (namespace-scope const variables), which runs
while the dynamic loader holds the glibc/ld.so loader lock.

On systems where /etc/os-version is missing or malformed, DSysInfo internally
emits qWarning(), which enters the dtklog appender pipeline. Meanwhile another
thread already holding the dtklog write lock formats %{function} via
QRegularExpression/pcre2, which can trigger TLS/loader initialization and
wait on the same loader lock. This forms a classic deadlock:

  Thread A: loader lock -&gt; DSysInfo -&gt; qWarning -&gt; wait dtklog lock
  Thread B: dtklog lock -&gt; %{function} regex/pcre2/TLS -&gt; wait loader lock

Replace the namespace-scope const globals (UosType, IsServerSystem,
IsCommunitySystem, etc.) with static inline lazy-init helper functions that
compute the value once on first runtime call via function-local statics.
This keeps the "compute once" semantics but moves the DSysInfo calls out of
the dlopen global constructor phase, breaking the loader-lock side of the
deadlock chain.

Affected plugins: sound, power, commoninfo, deepinid.
The helpers use `static inline` to preserve internal linkage (matching the
original const globals) and avoid ODR/symbol collisions across plugins that
share the same utils.h include guard name.

Log: defer DSysInfo queries in plugins to avoid dlopen deadlock

fix: 延迟插件中 DSysInfo 的调用以避免 dlopen 死锁

控制中心启动时通过 QPluginLoader 加载插件。多个插件在全局/静态初始化
（命名空间作用域 const 变量）中调用了 DSysInfo::uosType() 等接口，这些
代码在动态加载器持有 glibc/ld.so 加载锁期间执行。

当 /etc/os-version 缺失或格式异常时，DSysInfo 内部会触发 qWarning()，
进入 dtklog appender 写入流程。此时另一个线程已持有 dtklog 写锁，正在
格式化 %{function}，经由 QRegularExpression/pcre2 触发 TLS/加载器初始化，
并等待同一把加载锁，形成经典死锁：

  线程 A：加载锁 -&gt; DSysInfo -&gt; qWarning -&gt; 等待 dtklog 锁
  线程 B：dtklog 锁 -&gt; %{function} regex/pcre2/TLS -&gt; 等待加载锁

将命名空间作用域的 const 全局变量（UosType、IsServerSystem 等）替换为
static inline 懒加载辅助函数，通过函数局部 static 在首次运行时调用时
计算一次。保留"只计算一次"语义，但把 DSysInfo 调用移出 dlopen 全局构造
阶段，打断死锁链中加载锁一侧。

涉及插件：sound、power、commoninfo、deepinid。
辅助函数使用 static inline 保持内部链接（与原 const 全局变量一致），
避免多个共用 utils.h include guard 名的插件之间产生 ODR/符号冲突。

Log: 延迟插件中 DSysInfo 的调用以避免 dlopen 死锁
Change-Id: I1b72cc0a72252730e640997b5481c96f3989343e
diff --git a/src/plugin-commoninfo/operation/utils.h b/src/plugin-commoninfo/operation/utils.h
@@ -1,4 +1,4 @@
-//SPDX-FileCopyrightText: 2018 - 2023 UnionTech Software Technology Co., Ltd.
+//SPDX-FileCopyrightText: 2018 - 2026 UnionTech Software Technology Co., Ltd.
 //
 //SPDX-License-Identifier: GPL-3.0-or-later
 #ifndef UTILS_H
@@ -31,15 +31,47 @@ inline constexpr qint32 ActionIconSize=30;//大图标角标大小
 inline constexpr qint32 ActionListSize=26;//list图标角标大小
 
 
-const DSysInfo::UosType UosType = DSysInfo::uosType();
-const DSysInfo::UosEdition UosEdition = DSysInfo::uosEditionType();
-const bool IsServerSystem = (DSysInfo::UosServer == UosType);//是否是服务器版
-const bool IsCommunitySystem = (DSysInfo::UosCommunity == UosEdition);//是否是社区版
-const bool IsProfessionalSystem = (DSysInfo::UosProfessional == UosEdition);//是否是专业版
-const bool IsHomeSystem = (DSysInfo::UosHome == UosEdition);//是否是个人版
-const bool IsEducationSystem = (DSysInfo::UosEducation == UosEdition); // 是否是教育版
-const bool IsDeepinDesktop = (DSysInfo::DeepinDesktop == DSysInfo::deepinType());//是否是Deepin桌面
-const bool IsNotDeepinUos = !DSysInfo::isDeepin(); // 是否是 Deepin/Uos 以外的发行版
+static inline bool isServerSystem()
+{
+    static const bool serverSystem = DSysInfo::UosServer == DSysInfo::uosType();
+    return serverSystem;
+}
+
+static inline bool isCommunitySystem()
+{
+    static const bool communitySystem = DSysInfo::UosCommunity == DSysInfo::uosEditionType();
+    return communitySystem;
+}
+
+static inline bool isProfessionalSystem()
+{
+    static const bool professionalSystem = DSysInfo::UosProfessional == DSysInfo::uosEditionType();
+    return professionalSystem;
+}
+
+static inline bool isHomeSystem()
+{
+    static const bool homeSystem = DSysInfo::UosHome == DSysInfo::uosEditionType();
+    return homeSystem;
+}
+
+static inline bool isEducationSystem()
+{
+    static const bool educationSystem = DSysInfo::UosEducation == DSysInfo::uosEditionType();
+    return educationSystem;
+}
+
+static inline bool isDeepinDesktop()
+{
+    static const bool deepinDesktop = DSysInfo::DeepinDesktop == DSysInfo::deepinType();
+    return deepinDesktop;
+}
+
+static inline bool isNotDeepinUos()
+{
+    static const bool notDeepinUos = !DSysInfo::isDeepin();
+    return notDeepinUos;
+}
 
 
 template <typename T>
diff --git a/src/plugin-deepinid/operation/deepinidinterface.cpp b/src/plugin-deepinid/operation/deepinidinterface.cpp
@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: 2025 UnionTech Software Technology Co., Ltd.
+// SPDX-FileCopyrightText: 2025 - 2026 UnionTech Software Technology Co., Ltd.
 //
 // SPDX-License-Identifier: GPL-3.0-or-later
 
@@ -16,7 +16,7 @@ DeepinIDInterface::DeepinIDInterface(QObject *parent)
 
 QString DeepinIDInterface::editionName() const
 {
-    if (IsCommunitySystem) {
+    if (isCommunitySystem()) {
         return tr("deepin");
     } else {
         return tr("UOS");
diff --git a/src/plugin-deepinid/operation/deepinidworker.cpp b/src/plugin-deepinid/operation/deepinidworker.cpp
@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: 2025 UnionTech Software Technology Co., Ltd.
+// SPDX-FileCopyrightText: 2025 - 2026 UnionTech Software Technology Co., Ltd.
 //
 // SPDX-License-Identifier: GPL-3.0-or-later
 
@@ -407,7 +407,7 @@ QString DeepinWorker::loadCodeURL()
     };
 
     QString oauthURI = "https://login.uniontech.com";
-    if (IsCommunitySystem) {
+    if (isCommunitySystem()) {
         oauthURI = "https://login.deepin.org";
     }
 
@@ -422,7 +422,7 @@ QString DeepinWorker::loadCodeURL()
 
 void DeepinWorker::getLicenseState()
 {
-    if (IsCommunitySystem) {
+    if (isCommunitySystem()) {
         m_model->setActivation(true);
         return;
     }
diff --git a/src/plugin-deepinid/operation/utils.cpp b/src/plugin-deepinid/operation/utils.cpp
@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: 2025 UnionTech Software Technology Co., Ltd.
+// SPDX-FileCopyrightText: 2025 - 2026 UnionTech Software Technology Co., Ltd.
 //
 // SPDX-License-Identifier: GPL-3.0-or-later
 
@@ -27,9 +27,9 @@ QString getUrlTitle()
 {
     QString url;
     if (qEnvironmentVariableIsEmpty("DEEPIN_PRE")) {
-        url = IsCommunitySystem ? QStringLiteral("https://login.deepin.org") : QStringLiteral("https://login.uniontech.com");
+        url = isCommunitySystem() ? QStringLiteral("https://login.deepin.org") : QStringLiteral("https://login.uniontech.com");
     } else {
-        url = IsCommunitySystem ? QStringLiteral("https://login-pre.deepin.org") : QStringLiteral("https://login-pre.uniontech.com");
+        url = isCommunitySystem() ? QStringLiteral("https://login-pre.deepin.org") : QStringLiteral("https://login-pre.uniontech.com");
     }
     return url;
 }
@@ -196,12 +196,12 @@ QStringList getDeviceInfo()
 
 QString getEditionName()
 {
-    return IsCommunitySystem ? "deepin" : "UOS";
+    return isCommunitySystem() ? "deepin" : "UOS";
 }
 
 QString getIconName()
 {
-    return IsCommunitySystem ? "deepin-id" : "uos-id";
+    return isCommunitySystem() ? "deepin-id" : "uos-id";
 }
 
 }; // namespace utils
diff --git a/src/plugin-deepinid/operation/utils.h b/src/plugin-deepinid/operation/utils.h
@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: 2025 UnionTech Software Technology Co., Ltd.
+// SPDX-FileCopyrightText: 2025 - 2026 UnionTech Software Technology Co., Ltd.
 //
 // SPDX-License-Identifier: GPL-3.0-or-later
 
@@ -31,13 +31,35 @@ DCORE_USE_NAMESPACE
 #define DEEPINCLIENT_PATH QStringLiteral("/com/deepin/deepinid/Client")
 #define DEEPINCLIENT_INTERFACE QStringLiteral("com.deepin.deepinid.Client")
 
-const DSysInfo::UosType UosType = DSysInfo::uosType();
-const DSysInfo::UosEdition UosEdition = DSysInfo::uosEditionType();
-const bool IsServerSystem = (DSysInfo::UosServer == UosType);          // 是否是服务器版
-const bool IsCommunitySystem = (DSysInfo::UosCommunity == UosEdition); // 是否是社区版
-const bool IsProfessionalSystem = (DSysInfo::UosProfessional == UosEdition); // 是否是专业版
-const bool IsHomeSystem = (DSysInfo::UosHome == UosEdition);                 // 是否是个人版
-const bool IsDeepinDesktop = (DSysInfo::DeepinDesktop == DSysInfo::deepinType()); // 是否是Deepin桌面
+static inline bool isServerSystem()
+{
+    static const bool serverSystem = DSysInfo::UosServer == DSysInfo::uosType();
+    return serverSystem;
+}
+
+static inline bool isCommunitySystem()
+{
+    static const bool communitySystem = DSysInfo::UosCommunity == DSysInfo::uosEditionType();
+    return communitySystem;
+}
+
+static inline bool isProfessionalSystem()
+{
+    static const bool professionalSystem = DSysInfo::UosProfessional == DSysInfo::uosEditionType();
+    return professionalSystem;
+}
+
+static inline bool isHomeSystem()
+{
+    static const bool homeSystem = DSysInfo::UosHome == DSysInfo::uosEditionType();
+    return homeSystem;
+}
+
+static inline bool isDeepinDesktop()
+{
+    static const bool deepinDesktop = DSysInfo::DeepinDesktop == DSysInfo::deepinType();
+    return deepinDesktop;
+}
 
 enum SyncType {
     Sound,
diff --git a/src/plugin-power/operation/powermodel.cpp b/src/plugin-power/operation/powermodel.cpp
@@ -1,4 +1,4 @@
-//SPDX-FileCopyrightText: 2018 - 2023 UnionTech Software Technology Co., Ltd.
+//SPDX-FileCopyrightText: 2018 - 2026 UnionTech Software Technology Co., Ltd.
 //
 //SPDX-License-Identifier: GPL-3.0-or-later
 #include "powermodel.h"
@@ -331,7 +331,7 @@ void PowerModel::setBalancePerformanceSupported(bool isBalancePerformanceSupport
 
 void PowerModel::setSuspend(bool suspend)
 {
-    bool enable = !IsServerSystem && suspend;
+    bool enable = !isServerSystem() && suspend;
     if (m_isSuspend != enable) {
         m_isSuspend = enable;
 
@@ -341,7 +341,7 @@ void PowerModel::setSuspend(bool suspend)
 
 void PowerModel::setHibernate(bool hibernate)
 {
-    bool enable = !IsServerSystem && hibernate;
+    bool enable = !isServerSystem() && hibernate;
     if (m_isHibernate != enable) {
         m_isHibernate = enable;
 
diff --git a/src/plugin-power/operation/utils.h b/src/plugin-power/operation/utils.h
@@ -1,4 +1,4 @@
-//SPDX-FileCopyrightText: 2018 - 2023 UnionTech Software Technology Co., Ltd.
+//SPDX-FileCopyrightText: 2018 - 2026 UnionTech Software Technology Co., Ltd.
 //
 //SPDX-License-Identifier: GPL-3.0-or-later
 #ifndef UTILS_H
@@ -35,9 +35,11 @@ T valueByQSettings(const QStringList& configFiles,
     return failback.value<T>();
 }
 
-inline const static Dtk::Core::DSysInfo::UosType UosType = Dtk::Core::DSysInfo::uosType();
-inline const static bool IsServerSystem =
-        (Dtk::Core::DSysInfo::UosServer == UosType); // 是否是服务器版
+static inline bool isServerSystem()
+{
+    static const bool serverSystem = Dtk::Core::DSysInfo::UosServer == Dtk::Core::DSysInfo::uosType();
+    return serverSystem;
+}
 
 inline static bool isVirtualEnvironment()
 {
diff --git a/src/plugin-sound/operation/soundmodel.cpp b/src/plugin-sound/operation/soundmodel.cpp
@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: 2024 - 2027 UnionTech Software Technology Co., Ltd.
+// SPDX-FileCopyrightText: 2024 - 2026 UnionTech Software Technology Co., Ltd.
 //
 // SPDX-License-Identifier: GPL-3.0-or-later
 #include "soundmodel.h"
@@ -13,8 +13,11 @@
 
 Q_LOGGING_CATEGORY(DdcSoundModel, "dcc-sound-model")
 
-const static Dtk::Core::DSysInfo::UosType UosType = Dtk::Core::DSysInfo::uosType();
-const static bool IsServerSystem = (Dtk::Core::DSysInfo::UosServer == UosType); //是否是服务器版
+static bool isServerSystem()
+{
+    static const bool serverSystem = Dtk::Core::DSysInfo::UosServer == Dtk::Core::DSysInfo::uosType();
+    return serverSystem;
+}
 
 static const QMap<DDesktopServices::SystemSoundEffect, QString> SOUND_EFFECT_MAP{
     { DDesktopServices::SystemSoundEffect::SSE_Notifications, "message" },
@@ -97,7 +100,7 @@ SoundModel::SoundModel(QObject *parent)
         { tr("Error"), DDesktopServices::SSE_Error },
     };
 
-    if (IsServerSystem) {
+    if (isServerSystem()) {
         m_soundEffectMapBattery.removeOne({ tr("Wake up"), DDesktopServices::SSE_WakeUp });
         m_soundEffectMapPower.removeOne({ tr("Wake up"), DDesktopServices::SSE_WakeUp });
     }
@@ -733,4 +736,3 @@ void SoundModel::setShowInputBluetoothMode(bool newShowInputBluetoothMode)
     m_showInputBluetoothMode = newShowInputBluetoothMode;
     emit showInputBluetoothModeChanged();
 }
-

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-// SPDX-FileCopyrightText: 2025 UnionTech Software Technology Co., Ltd.`
	`1`	`+// SPDX-FileCopyrightText: 2025 - 2026 UnionTech Software Technology Co., Ltd.`
`2`	`2`	`//`
`3`	`3`	`// SPDX-License-Identifier: GPL-3.0-or-later`
`4`	`4`
`@@ -407,7 +407,7 @@ QString DeepinWorker::loadCodeURL()`
`407`	`407`	`};`
`408`	`408`
`409`	`409`	`QString oauthURI = "https://login.uniontech.com";`
`410`		`- if (IsCommunitySystem) {`
	`410`	`+ if (isCommunitySystem()) {`
`411`	`411`	`oauthURI = "https://login.deepin.org";`
`412`	`412`	`}`
`413`	`413`
`@@ -422,7 +422,7 @@ QString DeepinWorker::loadCodeURL()`
`422`	`422`
`423`	`423`	`void DeepinWorker::getLicenseState()`
`424`	`424`	`{`
`425`		`- if (IsCommunitySystem) {`
	`425`	`+ if (isCommunitySystem()) {`
`426`	`426`	`m_model->setActivation(true);`
`427`	`427`	`return;`
`428`	`428`	`}`