refactor: move plugin factory preparation before module loading

1. Extracted plugin factory preparation logic from
LoadPluginTask::doLoadSo() into new method preparePluginFactory()
2. Modified LoadPluginTask::doLoadSo() to LoadPluginTask::createData()
that uses pre-prepared factory
3. Added factory pointer to PluginData structure to store prepared
factory instance
4. Moved factory preparation to occur before loadModule() in plugin
loading sequence
5. Simplified createData() method to focus only on object creation from
factory
6. Added proper cleanup of factory pointer in PluginManager destructor

This refactoring separates factory preparation from object creation,
allowing factory initialization to happen earlier in the plugin loading
process. The change improves code organization by separating concerns:
factory loading/validation vs. object instantiation. This prepares
for potential optimizations where factory preparation could be done in
parallel or at different stages of application startup.

Influence:
1. Verify plugin loading still works correctly for all control center
modules
2. Test plugin loading with both valid and invalid .so files
3. Verify error handling when factory preparation fails
4. Test memory management and cleanup of factory instances
5. Ensure plugin status updates are still emitted correctly
6. Verify thread safety during factory preparation and object creation
7. Test with plugins that have parent/child relationships in their
created objects

refactor: 将插件工厂准备逻辑前移到模块加载之前执行

1. 从 LoadPluginTask::doLoadSo() 中提取插件工厂准备逻辑到新的
preparePluginFactory() 方法
2. 将 LoadPluginTask::doLoadSo() 重命名为 LoadPluginTask::createData()，
使用预先准备的工厂
3. 在 PluginData 结构中添加工厂指针以存储准备好的工厂实例
4. 将工厂准备移动到插件加载序列中的 loadModule() 之前执行
5. 简化 createData() 方法，专注于从工厂创建对象
6. 在 PluginManager 析构函数中添加工厂指针的适当清理

此次重构将工厂准备与对象创建分离，允许工厂初始化在插件加载过程的更早阶段
进行。这一改动通过分离关注点（工厂加载/验证 vs. 对象实例化）改善了代码组
织。这为潜在的优化做好了准备，工厂准备可以并行进行或在应用程序启动的不同
阶段执行。

Influence:
1. 验证所有控制中心模块的插件加载是否仍然正常工作
2. 测试使用有效和无效 .so 文件的插件加载
3. 验证工厂准备失败时的错误处理
4. 测试工厂实例的内存管理和清理
5. 确保插件状态更新仍然正确发出
6. 验证工厂准备和对象创建期间的线程安全性
7. 测试具有父子关系的插件对象的创建

Author: 18202781743

src/dde-control-center/pluginmanager.cpp

@@ -75,6 +75,7 @@ struct PluginData
     QString name;
     QString path;
     uint type;
+    DccFactory *factory;
 
     DccObject *module;
     DccObject *mainObj;
@@ -87,6 +88,7 @@ struct PluginData
         : name(_name)
         , path(_path)
         , type(T_Unknown)
+        , factory(nullptr)
         , module(nullptr)
         , mainObj(nullptr)
         , soObj(nullptr)
@@ -111,7 +113,7 @@ class LoadPluginTask : public QRunnable
 
 protected:
     void run() override;
-    void doLoadSo();
+    void createData();
 
 protected:
     PluginManager *m_pManager;
@@ -121,62 +123,33 @@ class LoadPluginTask : public QRunnable
 void LoadPluginTask::run()
 {
     m_data->thread = QThread::currentThread();
-    doLoadSo();
+    createData();
     m_data->thread = nullptr;
 }
 
-void LoadPluginTask::doLoadSo()
+void LoadPluginTask::createData()
 {
-    Q_EMIT m_pManager->updatePluginStatus(m_data, DataBegin, "load plugin begin");
-    // {main.qml}
-    const QString soPath = m_data->path + "/" + m_data->name + ".so";
+    Q_EMIT m_pManager->updatePluginStatus(m_data, DataBegin, "create data begin");
     QElapsedTimer timer;
     timer.start();
     QObject *dataObj = nullptr;
     DccObject *soObj = nullptr;
-    if (QFile::exists(soPath)) {
-        if (m_pManager->isDeleting()) {
-            return;
-        }
-        QPluginLoader loader(soPath);
+    if (m_pManager->isDeleting()) {
+        return;
+    }
+    if (!m_data->factory) {
+        Q_EMIT m_pManager->updatePluginStatus(m_data, DataEnd, ": create data skipped");
+        return;
+    } else {
         Q_EMIT m_pManager->updatePluginStatus(m_data, DataLoad, QString());
-        loader.load();
-        if (m_pManager->isDeleting()) {
-            return;
+        dataObj = m_data->factory->create();
+        if (dataObj && dataObj->parent()) {
+            dataObj->setParent(nullptr);
         }
-        if (!loader.isLoaded()) {
-            Q_EMIT m_pManager->updatePluginStatus(m_data, DataErr, "Load the plugin failed." + loader.errorString());
-        } else {
-            const auto &meta = loader.metaData();
-            do {
-                const auto iid = meta["IID"].toString();
-                if (iid.isEmpty() || iid != QString(qobject_interface_iid<DccFactory *>())) {
-                    Q_EMIT m_pManager->updatePluginStatus(m_data, DataErr, "Error iid:" + iid);
-                    break;
-                }
-
-                if (!loader.instance()) {
-                    Q_EMIT m_pManager->updatePluginStatus(m_data, DataErr, "instance() failed." + loader.errorString());
-                    break;
-                }
-                DccFactory *factory = qobject_cast<DccFactory *>(loader.instance());
-                if (!factory) {
-                    Q_EMIT m_pManager->updatePluginStatus(m_data, DataErr, "The plugin isn't a DccFactory." + soPath);
-                    loader.unload();
-                    break;
-                }
-                dataObj = factory->create();
-                if (dataObj && dataObj->parent()) {
-                    dataObj->setParent(nullptr);
-                }
-                soObj = factory->dccObject();
-                if (soObj && soObj->parent()) {
-                    soObj->setParent(nullptr);
-                }
-            } while (false);
+        soObj = m_data->factory->dccObject();
+        if (soObj && soObj->parent()) {
+            soObj->setParent(nullptr);
         }
-    } else {
-        Q_EMIT m_pManager->updatePluginStatus(m_data, DataErr, "File does not exist:" + soPath);
     }
     if (dataObj) {
         m_data->data = dataObj;
@@ -192,7 +165,7 @@ void LoadPluginTask::doLoadSo()
         m_data->soObj->moveToThread(m_pManager->thread());
         m_data->soObj->setParent(m_pManager->parent());
     }
-    Q_EMIT m_pManager->updatePluginStatus(m_data, DataEnd, ": load plugin finished. elapsed time :" + QString::number(timer.elapsed()));
+    Q_EMIT m_pManager->updatePluginStatus(m_data, DataEnd, ": create data finished. elapsed time :" + QString::number(timer.elapsed()));
 }
 
 PluginManager::PluginManager(DccManager *parent)
@@ -224,6 +197,7 @@ PluginManager::~PluginManager()
             delete data->data;
             data->data = nullptr;
         }
+        data->factory = nullptr;
         delete data;
     }
     m_plugins.clear();
@@ -305,6 +279,49 @@ bool PluginManager::updatePluginType(PluginData *plugin)
     return false;
 }
 
+bool PluginManager::preparePluginFactory(PluginData *plugin)
+{
+    if (!plugin || plugin->factory) {
+        return plugin && plugin->factory;
+    }
+
+    const QString soPath = plugin->path + "/" + plugin->name + ".so";
+    if (!QFile::exists(soPath)) {
+        return true;
+    }
+
+    QPluginLoader loader(soPath);
+    if (!loader.load()) {
+        qCWarning(dccLog()) << plugin->name << ": prepare factory load failed" << loader.errorString();
+        return false;
+    }
+
+    const auto &meta = loader.metaData();
+    const auto iid = meta["IID"].toString();
+    if (iid.isEmpty() || iid != QString(qobject_interface_iid<DccFactory *>())) {
+        qCWarning(dccLog()) << plugin->name << ": prepare factory iid error" << iid;
+        loader.unload();
+        return false;
+    }
+
+    QObject *instance = loader.instance();
+    if (!instance) {
+        qCWarning(dccLog()) << plugin->name << ": prepare factory instance failed" << loader.errorString();
+        loader.unload();
+        return false;
+    }
+
+    DccFactory *factory = qobject_cast<DccFactory *>(instance);
+    if (!factory) {
+        qCWarning(dccLog()) << plugin->name << ": prepare factory cast failed";
+        loader.unload();
+        return false;
+    }
+
+    plugin->factory = factory;
+    return true;
+}
+
 QThreadPool *PluginManager::threadPool()
 {
     if (!m_threadPool) {
@@ -341,6 +358,10 @@ void PluginManager::loadPlugin(PluginData *plugin)
             threadPool()->start(new LoadPluginTask(plugin, this));
         }
     } else if ((plugin->status & (MetaDataEnd | ModuleLoad)) == MetaDataEnd) {
+        if (!preparePluginFactory(plugin)) {
+            Q_EMIT updatePluginStatus(plugin, DataErr | PluginEnd, ": factory preparation failed, plugin skipped");
+            return;
+        }
         DccManager::installTranslator(plugin->name);
         loadModule(plugin);
     } else {

src/dde-control-center/pluginmanager.h

@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: 2024 - 2027 UnionTech Software Technology Co., Ltd.
+// SPDX-FileCopyrightText: 2024 - 2026 UnionTech Software Technology Co., Ltd.
 //
 // SPDX-License-Identifier: GPL-3.0-or-later
 #pragma once
@@ -8,7 +8,6 @@
 #include <QStringList>
 #include <QVector>
 
-class QPluginLoader;
 class QQmlComponent;
 class QThreadPool;
 
@@ -42,6 +41,7 @@ public Q_SLOTS:
 private:
     bool compareVersion(const QString &targetVersion, const QString &baseVersion);
     bool updatePluginType(PluginData *plugin);
+    bool preparePluginFactory(PluginData *plugin);
     QThreadPool *threadPool();
 
 private Q_SLOTS: