chore: remove touchpad switch file existence check#2908
Merged
Conversation
Removed the touchpad switch file existence check functionality from the mouse settings plugin. The implementation included: 1. Deleted touchpadSwitchFileExists() method from MouseModel class 2. Removed corresponding Q_PROPERTY declaration from header file 3. Eliminated visibility condition based on file existence in QML UI This change was made because the touchpad switch file check is no longer needed in the current system configuration. The file path "/proc/ uos/touchpad_switch" was specific to a particular environment and the functionality has become obsolete with system updates. Log: Removed touchpad switch file existence verification from mouse settings Influence: 1. Verify touchpad settings page loads correctly without file existence check 2. Test touchpad functionality remains operational 3. Confirm no regression in mouse/touchpad configuration options 4. Validate UI layout consistency after removing the conditional visibility chore: 移除触摸板开关文件存在性检查 从鼠标设置插件中移除了触摸板开关文件存在性检查功能。具体修改包括: 1. 从 MouseModel 类中删除了 touchpadSwitchFileExists() 方法 2. 从头文件中移除了对应的 Q_PROPERTY 声明 3. 在 QML 界面中移除了基于文件存在性的可见性条件 进行此更改是因为在当前系统配置中不再需要触摸板开关文件检查。文件路径 "/ proc/uos/touchpad_switch" 特定于某个环境,随着系统更新该功能已变得过时。 Log: 从鼠标设置中移除了触摸板开关文件存在性验证 PMS: BUG-342407 Influence: 1. 验证触摸板设置页面在没有文件存在性检查时正确加载 2. 测试触摸板功能保持正常运行 3. 确认鼠标/触摸板配置选项没有回归问题 4. 验证移除条件可见性后 UI 布局的一致性
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRemoves the obsolete touchpad switch existence check from the mouse settings plugin by deleting the backing C++ API and the QML visibility binding that depended on it. Class diagram for MouseModel touchpadSwitchFileExists removalclassDiagram
class OldMouseModel {
<<QObject>>
+bool tapEnabled
+QString gestureFingerAniPath
+QString gestureActionAniPath
+int cursorSize
+QList~int~ availableCursorSizes
+bool touchpadSwitchFileExists()
}
class NewMouseModel {
<<QObject>>
+bool tapEnabled
+QString gestureFingerAniPath
+QString gestureActionAniPath
+int cursorSize
+QList~int~ availableCursorSizes
}
OldMouseModel <|-- NewMouseModel
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
caixr23
approved these changes
Dec 29, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: caixr23, fly602 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
deepin pr auto review我来对这段代码的变更进行审查:
潜在问题:
改进建议:
总结: |
Contributor
Author
|
/forcemerge |
|
This pr force merged! (status: blocked) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the touchpad switch file existence check functionality from the mouse settings plugin. The implementation included:
This change was made because the touchpad switch file check is no longer needed in the current system configuration. The file path "/proc/ uos/touchpad_switch" was specific to a particular environment and the functionality has become obsolete with system updates.
Log: Removed touchpad switch file existence verification from mouse settings
Influence:
chore: 移除触摸板开关文件存在性检查
从鼠标设置插件中移除了触摸板开关文件存在性检查功能。具体修改包括:
进行此更改是因为在当前系统配置中不再需要触摸板开关文件检查。文件路径 "/
proc/uos/touchpad_switch" 特定于某个环境,随着系统更新该功能已变得过时。
Log: 从鼠标设置中移除了触摸板开关文件存在性验证
PMS: BUG-342407
Influence:
Summary by Sourcery
Remove the obsolete touchpad switch file existence check from the mouse settings plugin.
Enhancements: