fix(personalization): remove unreliable 2x2 image for wallpaper dark …#3313
Conversation
…type detection Remove the 2x2 Image component and grabToImage logic used to detect wallpaper dark/light type, as it is unreliable and impacts wallpaper loading performance. Pass a hardcoded isDarkType value as a temporary placeholder. 删除用于检测壁纸深色/浅色类型的 2x2 Image 组件和 grabToImage 逻辑, 因为该方案不可靠且影响壁纸加载性能。暂时硬编码 isDarkType 值作为占位。 Log: remove unreliable 2x2 image for wallpaper dark type detection to improve loading performance
deepin pr auto review★ 总体评分:100分■ 【总体评价】
■ 【详细分析】
■ 【改进建议代码示例】 // 当前diff已完美修复该逻辑缺陷,无需额外代码示例
// 修复核心在于移除WallpaperSelectView.qml中的img2x2控件及grabToImage调用
// 并将整条setWallpaperForMonitor调用链中的isDark参数彻底剔除 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mhduiy, robertkill The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/forcemerge |
|
This pr force merged! (status: blocked) |
…type detection
Remove the 2x2 Image component and grabToImage logic used to detect wallpaper dark/light type, as it is unreliable and impacts wallpaper loading performance. Pass a hardcoded isDarkType value as a temporary placeholder.
删除用于检测壁纸深色/浅色类型的 2x2 Image 组件和 grabToImage 逻辑,
因为该方案不可靠且影响壁纸加载性能。暂时硬编码 isDarkType 值作为占位。
Log: remove unreliable 2x2 image for wallpaper dark type detection to improve loading performance