Skip to content

fix: adjust focus policy for group edit button in account settings#3325

Open
xujin177 wants to merge 1 commit into
linuxdeepin:masterfrom
xujin177:bugfix/focus_error
Open

fix: adjust focus policy for group edit button in account settings#3325
xujin177 wants to merge 1 commit into
linuxdeepin:masterfrom
xujin177:bugfix/focus_error

Conversation

@xujin177

@xujin177 xujin177 commented Jun 30, 2026

Copy link
Copy Markdown

Changed the focus policy from Qt.StrongFocus to Qt.TabFocus for the group edit button in account settings UI. This fixes the issue where the button could capture focus via mouse click unnecessarily, ensuring focus is only gained through tab navigation as intended while maintaining the button's accessibility for keyboard users.

Log: Fixed focus behavior of group edit button in account settings

Influence:

  1. Verify tab navigation order through account settings page
  2. Test clicking on the edit button and confirm no unwanted focus capture
  3. Test keyboard-only navigation to ensure the button remains accessible
  4. Verify that the edit/done button function works correctly after focus change

fix: 调整账户设置中分组编辑按钮的焦点策略

将分组编辑按钮的焦点策略从 Qt.StrongFocus 修改为 Qt.TabFocus,修复了 按钮通过鼠标点击不必要地获取焦点的问题,确保焦点仅通过Tab键导航获得,同
时保持按钮对键盘用户的可访问性。

Log: 修复账户设置中编辑按钮的焦点行为

Influence:

  1. 验证账户设置页面的Tab键导航顺序
  2. 测试点击编辑按钮,确认不会不必要地捕获焦点
  3. 测试仅通过键盘导航,确保按钮依然可访问
  4. 验证焦点策略修改后编辑/完成按钮功能正常

PMS: BUG-361555

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @xujin177, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xujin177

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot

Copy link
Copy Markdown

Hi @xujin177. Thanks for your PR. 😃

@deepin-ci-robot

Copy link
Copy Markdown

Hi @xujin177. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xujin177 xujin177 force-pushed the bugfix/focus_error branch from 9b039ba to e837b6f Compare June 30, 2026 13:18
Changed the focus policy from `Qt.StrongFocus` to `Qt.TabFocus` for the
group edit button in account settings UI. This fixes the issue where the
button could capture focus via mouse click unnecessarily, ensuring focus
is only gained through tab navigation as intended while maintaining the
button's accessibility for keyboard users.

Log: Fixed focus behavior of group edit button in account settings

Influence:
1. Verify tab navigation order through account settings page
2. Test clicking on the edit button and confirm no unwanted focus
capture
3. Test keyboard-only navigation to ensure the button remains accessible
4. Verify that the edit/done button function works correctly after focus
change

fix: 调整账户设置中分组编辑按钮的焦点策略

将分组编辑按钮的焦点策略从 `Qt.StrongFocus` 修改为 `Qt.TabFocus`,修复了
按钮通过鼠标点击不必要地获取焦点的问题,确保焦点仅通过Tab键导航获得,同
时保持按钮对键盘用户的可访问性。

Log: 修复账户设置中编辑按钮的焦点行为

Influence:
1. 验证账户设置页面的Tab键导航顺序
2. 测试点击编辑按钮,确认不会不必要地捕获焦点
3. 测试仅通过键盘导航,确保按钮依然可访问
4. 验证焦点策略修改后编辑/完成按钮功能正常

PMS: BUG-361555
@xujin177 xujin177 force-pushed the bugfix/focus_error branch from e837b6f to 349a7ac Compare June 30, 2026 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants