fix(dcc-plugin): adjust MenuEditor switch and arrow alignment#3339
fix(dcc-plugin): adjust MenuEditor switch and arrow alignment#3339iCancely wants to merge 1 commit into
Conversation
|
CLA Assistant Lite bot: |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts layout spacing and visibility handling in DccMenuEditorItem to correctly align the switch relative to the arrow icon and right edge of the menu list. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider whether the inactive
DccLoadershould also explicitly setvisible: activeorvisible: !editorfor clarity and consistency in how loader visibility is handled. - The hard-coded spacing and right offset values (8px, 10px, 30px) might be better expressed via shared constants or theme metrics to keep alignment consistent across similar UI elements.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider whether the inactive `DccLoader` should also explicitly set `visible: active` or `visible: !editor` for clarity and consistency in how loader visibility is handled.
- The hard-coded spacing and right offset values (8px, 10px, 30px) might be better expressed via shared constants or theme metrics to keep alignment consistent across similar UI elements.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
I have read the CLA Document and I hereby sign the CLA. |
|
recheck |
570766d to
905ae35
Compare
905ae35 to
acf38b0
Compare
1. Reduce RowLayout spacing from 10px to 8px between switch and arrow icon 2. Remove redundant visible: active from Loader since active already controls component lifecycle 3. Ensure switch controls are positioned 30px from the list background right edge, consistent with the arrow icon's 10px right padding Log: Fix MenuEditorItem layout so switch and arrow are properly aligned to 30px from the right edge fix(dcc-plugin): 调整MenuEditor开关和箭头的对齐 1. 将RowLayout间距从10px缩减为8px 2. 移除Loader上多余的visible: active,active已控制组件加载 3. 确保开关控件距列表背景右侧30px,与箭头图标的10px右边距对齐 Log: 修复MenuEditorItem布局,使开关和箭头距列表右边缘30px对齐 PMS: BUG-369103
acf38b0 to
332d10e
Compare
deepin pr auto review★ 总体评分:100分■ 【总体评价】
■ 【详细分析】
■ 【改进建议代码示例】 DccEditorItem {
bottomPadding: bottomInset
activeFocusOnTab: false
rightItem: RowLayout {
spacing: 8
DccLoader {
active: !editor
dccObj: model.item
}
}
} |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, iCancely, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
component lifecycle
right edge, consistent with the arrow icon's 10px right padding
Log: Fix MenuEditorItem layout so switch and arrow are properly aligned to 30px from the right edge
Log: 修复MenuEditorItem布局,使开关和箭头距列表右边缘30px对齐
PMS: BUG-369103