Skip to content

feat: implement optical disc sharing service#3689

Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
Johnson-zs:master
Apr 7, 2026
Merged

feat: implement optical disc sharing service#3689
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
Johnson-zs:master

Conversation

@Johnson-zs
Copy link
Copy Markdown
Contributor

Add new D-Bus service for optical disc state and attribute sharing
between processes. Replace file-based persistence with D-Bus service
to enable cross-process optical disc information sharing. The service
provides methods for managing burn states and attributes with proper
access control and signal notifications.

Key changes:

  1. Added new D-Bus service org.deepin.Filemanager.OpticalShare with
    system bus connection
  2. Implemented OpticalShareProxy for client-side D-Bus communication
  3. Replaced Settings-based persistence with D-Bus service calls
  4. Added proper cleanup when optical devices are removed
  5. Included caller UID and timestamp tracking for security

Log: Added optical disc sharing service for cross-process state
management

Influence:

  1. Test optical disc detection and state persistence
  2. Verify burn state changes are properly communicated between processes
  3. Test optical device removal cleanup
  4. Verify D-Bus service availability and error handling
  5. Test multi-user access control and security
  6. Validate signal notifications for state changes

feat: 实现光盘共享服务

新增用于进程间光盘状态和属性共享的 D-Bus 服务。将基于文件的持久化存储替
换为 D-Bus 服务,以实现跨进程的光盘信息共享。该服务提供管理刻录状态和属
性的方法,具有适当的访问控制和信号通知功能。

主要变更:

  1. 新增系统总线连接的 D-Bus 服务 org.deepin.Filemanager.OpticalShare
  2. 实现客户端 D-Bus 通信的 OpticalShareProxy
  3. 将基于 Settings 的持久化存储替换为 D-Bus 服务调用
  4. 添加光盘设备移除时的正确清理机制
  5. 包含调用者 UID 和时间戳跟踪以增强安全性

Log: 新增光盘共享服务,支持跨进程状态管理

Influence:

  1. 测试光盘检测和状态持久化功能
  2. 验证刻录状态变更在进程间正确通信
  3. 测试光盘设备移除的清理机制
  4. 验证 D-Bus 服务可用性和错误处理
  5. 测试多用户访问控制和安全性
  6. 验证状态变更的信号通知功能

Bug: https://pms.uniontech.com/bug-view-355565.html

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @Johnson-zs, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

  • 检测到debian目录文件有变更: debian/control

@deepin-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Johnson-zs

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

  • 检测到debian目录文件有变更: debian/control

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

  • 敏感词检查失败, 检测到1个文件存在敏感词
详情
{
    "debian/control": [
        {
            "line": "Homepage: http://www.deepin.org",
            "line_number": 55,
            "rule": "S35",
            "reason": "Url link | 6fe814dfb7"
        }
    ]
}

@Johnson-zs Johnson-zs force-pushed the master branch 2 times, most recently from 3907bcb to 70116b1 Compare April 7, 2026 01:25
Add new D-Bus service for optical disc state and attribute sharing
between processes. Replace file-based persistence with D-Bus service
to enable cross-process optical disc information sharing. The service
provides methods for managing burn states and attributes with proper
access control and signal notifications.

Key changes:
1. Added new D-Bus service org.deepin.Filemanager.OpticalShare with
system bus connection
2. Implemented OpticalShareProxy for client-side D-Bus communication
3. Replaced Settings-based persistence with D-Bus service calls
4. Added proper cleanup when optical devices are removed
5. Included caller UID and timestamp tracking for security

Log: Added optical disc sharing service for cross-process state
management

Influence:
1. Test optical disc detection and state persistence
2. Verify burn state changes are properly communicated between processes
3. Test optical device removal cleanup
4. Verify D-Bus service availability and error handling
5. Test multi-user access control and security
6. Validate signal notifications for state changes

feat: 实现光盘共享服务

新增用于进程间光盘状态和属性共享的 D-Bus 服务。将基于文件的持久化存储替
换为 D-Bus 服务,以实现跨进程的光盘信息共享。该服务提供管理刻录状态和属
性的方法,具有适当的访问控制和信号通知功能。

主要变更:
1. 新增系统总线连接的 D-Bus 服务 org.deepin.Filemanager.OpticalShare
2. 实现客户端 D-Bus 通信的 OpticalShareProxy
3. 将基于 Settings 的持久化存储替换为 D-Bus 服务调用
4. 添加光盘设备移除时的正确清理机制
5. 包含调用者 UID 和时间戳跟踪以增强安全性

Log: 新增光盘共享服务,支持跨进程状态管理

Influence:
1. 测试光盘检测和状态持久化功能
2. 验证刻录状态变更在进程间正确通信
3. 测试光盘设备移除的清理机制
4. 验证 D-Bus 服务可用性和错误处理
5. 测试多用户访问控制和安全性
6. 验证状态变更的信号通知功能

Bug: https://pms.uniontech.com/bug-view-355565.html
@Johnson-zs
Copy link
Copy Markdown
Contributor Author

/forcemerge

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot bot commented Apr 7, 2026

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit addd4a7 into linuxdeepin:master Apr 7, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants