feat: Add fuzzy search support for applications#538
Merged
Conversation
Reviewer's Guide by SourceryThis pull request introduces fuzzy search functionality for applications. It implements a fuzzy matching algorithm based on the longest common subsequence and uses a threshold to determine the minimum match score required for a successful match. The changes were made in Sequence diagram for fuzzy search in SearchFilterProxyModelsequenceDiagram
participant User
participant SearchFilterProxyModel
participant AppsModel
User->>SearchFilterProxyModel: Types search query
activate SearchFilterProxyModel
SearchFilterProxyModel->>SearchFilterProxyModel: filterAcceptsRow(sourceRow, sourceParent)
activate SearchFilterProxyModel
SearchFilterProxyModel->>AppsModel: displayName = data(Qt::DisplayRole)
activate AppsModel
AppsModel-->>SearchFilterProxyModel: Return displayName
deactivate AppsModel
SearchFilterProxyModel->>AppsModel: name = data(AppsModel::NameRole)
activate AppsModel
AppsModel-->>SearchFilterProxyModel: Return name
deactivate AppsModel
SearchFilterProxyModel->>AppsModel: transliterated = data(AppsModel::AllTransliteratedRole)
activate AppsModel
AppsModel-->>SearchFilterProxyModel: Return transliterated
deactivate AppsModel
SearchFilterProxyModel->>SearchFilterProxyModel: fuzzyMatch(displayName, pattern)
activate SearchFilterProxyModel
SearchFilterProxyModel-->>SearchFilterProxyModel: Return matchResult
deactivate SearchFilterProxyModel
SearchFilterProxyModel->>SearchFilterProxyModel: fuzzyMatch(name, pattern)
activate SearchFilterProxyModel
SearchFilterProxyModel-->>SearchFilterProxyModel: Return matchResult
deactivate SearchFilterProxyModel
SearchFilterProxyModel->>SearchFilterProxyModel: fuzzyMatch(transliterated, pattern)
activate SearchFilterProxyModel
SearchFilterProxyModel-->>SearchFilterProxyModel: Return matchResult
deactivate SearchFilterProxyModel
SearchFilterProxyModel-->>User: Return whether row is accepted
deactivate SearchFilterProxyModel
deactivate SearchFilterProxyModel
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @wjyrich - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider extracting the fuzzyMatch lambda to a named method for better readability.
- The fuzzy threshold should be configurable.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| } | ||
| } | ||
|
|
||
| float matchScore = static_cast<float>(dp[textLen][patternLen]) / patternLen; |
There was a problem hiding this comment.
issue (bug_risk): Division by zero risk when the search pattern is empty.
If searchPattern.pattern() yields an empty string, patternLen equals 0 and dividing by it will cause a runtime error. Consider adding a check to handle cases where the pattern is empty before performing the division.
| QString pattern = searchPattern.pattern().toLower().remove(" "); | ||
|
|
||
| // 模糊匹配函数 | ||
| auto fuzzyMatch = [this](const QString & modelData, const QString & pattern) -> bool { |
There was a problem hiding this comment.
suggestion: Consider extracting the fuzzyMatch logic for clarity or reuse.
The inline lambda is defined within filterAcceptsRow and recreated on every call. While this may be acceptable if the data is small, extracting it to a dedicated member function could improve readability and maintainability if similar fuzzy matching is required elsewhere or if the logic evolves further.
BLumia
reviewed
Apr 18, 2025
add fuzzy search. PMS-BUG-288459
deepin pr auto review关键摘要:
是否建议立即修改: |
BLumia
approved these changes
May 6, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BLumia, wjyrich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add fuzzy search.
PMS-BUG-288459
Summary by Sourcery
Implement fuzzy search functionality for application filtering, improving search flexibility and matching accuracy
New Features:
Enhancements: