Skip to content

乌克兰语翻译#540

Closed
wyy667788 wants to merge 3 commits into
linuxdeepin:masterfrom
wyy667788:master
Closed

乌克兰语翻译#540
wyy667788 wants to merge 3 commits into
linuxdeepin:masterfrom
wyy667788:master

Conversation

@wyy667788
Copy link
Copy Markdown

@wyy667788 wyy667788 commented Apr 20, 2025

修复了结尾字符的错误,

Summary by Sourcery

Documentation:

  • Added a complete translation file for the DDE Launchpad interface in Ukrainian language

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wyy667788

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link
Copy Markdown

Hi @wyy667788. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Apr 20, 2025

Reviewer's Guide by Sourcery

This pull request adds a new translation file for the Ukrainian language. All strings in the application have been translated.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added Ukrainian translation for the application.
  • Added translation file for Ukrainian language.
  • Translated all strings in the application to Ukrainian.
translations/dde-lauchpad_WKL.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 20, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @wyy667788 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Thanks for providing the translation, but could you provide some context on what the source language is?
Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment on lines +206 to +207
<source>Confirm</source>
<translation>Безумовно</translation>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Translation for 'Confirm' may not match standard usage.

The word 'Confirm' is typically translated as something akin to 'Підтвердити'. 'Безумовно' is more aligned with 'Absolutely' or an emphasis rather than a confirmation action. Consider reviewing this for user clarity.

Suggested change
<source>Confirm</source>
<translation>Безумовно</translation>
<source>Confirm</source>
<translation>Підтвердити</translation>

Comment on lines +271 to +272
<source>Desktop</source>
<translation>настільний</translation>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Translation for 'Desktop' is potentially imprecise.

Typically, the term 'Desktop' in this context is translated as 'робочий стіл'. The current translation 'настільний' might be interpreted as an adjective rather than the noun for a computer desktop. Verify if this is the intended expression.

Suggested change
<source>Desktop</source>
<translation>настільний</translation>
<source>Desktop</source>
<translation>робочий стіл</translation>

@wyy667788
Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA.

deepin-bot Bot added a commit to linuxdeepin/cla that referenced this pull request Apr 20, 2025
Copy link
Copy Markdown
Member

@BLumia BLumia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 乌克兰语的语言代码是 uk,不是拼音首字母的 WKL,这个写法无法被程序识别。
  2. 翻译需要在 Transifex 平台进行,不通过 GitHub
  3. 请问你是乌克兰语用户吗?如果是,非常建议你移步 https://www.deepin.org/developer-community/internationalization/ 并根据说明加入相关群组进行后续贡献。

@BLumia
Copy link
Copy Markdown
Member

BLumia commented Apr 27, 2025

未见进一步讨论与修改,关闭处理。关闭原因见 #540 (review)

@BLumia BLumia closed this Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants