fix: Uninstalling app in fullscreen doesn't close launcher#549
Conversation
Reviewer's GuideThis pull request prevents the launcher from being hidden when an app is uninstalled from fullscreen mode by adding a conditional check in Sequence Diagram for Conditional Launcher Visibility on UninstallsequenceDiagram
actor User
participant AppItemMenu
participant LauncherController
User->>AppItemMenu: Trigger Uninstall
AppItemMenu->>LauncherController: Get currentFrame
alt currentFrame is not "FullscreenFrame"
AppItemMenu->>LauncherController: Set visible = false
else currentFrame is "FullscreenFrame"
AppItemMenu-->>LauncherController: Do not set visible = false (Launcher remains visible)
end
note right of AppItemMenu: Continue with showing uninstall confirmation
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @wjyrich - I've reviewed your changes - here's some feedback:
- The commented-out code in
launcheritem.qmlseems unrelated to the fullscreen uninstall fix; please clarify if this change is intentional.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
wjyrich
force-pushed
the
fix-bug-315255
branch
2 times, most recently
from
19a4fc9 to
86a43f3
Compare
fix Uninstalling an app in full screen doesn't close launcher pms-bug-315255
deepin pr auto review代码审查意见：
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BLumia, wjyrich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
3 participants
fix Uninstalling an app in full screen doesn't close launcher
pms-bug-315255
Summary by Sourcery
Bug Fixes: