Skip to content

fix: Add quotation marks to the app name in the uninstall dialog#550

Merged
BLumia merged 1 commit into
linuxdeepin:masterfrom
wjyrich:fix-bug-315259
May 8, 2025
Merged

fix: Add quotation marks to the app name in the uninstall dialog#550
BLumia merged 1 commit into
linuxdeepin:masterfrom
wjyrich:fix-bug-315259

Conversation

@wjyrich
Copy link
Copy Markdown
Contributor

@wjyrich wjyrich commented May 8, 2025

add "" for app uninstall

pms-bug-315259

Summary by Sourcery

Bug Fixes:

  • Fixed uninstall dialog text to properly format the app name with quotation marks

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2025

CLA Assistant Lite bot:
提交邮箱中包含我们的合作伙伴,但您似乎并非合作伙伴的成员或对接人,请联系相关对接人将您添加至组织之中,或由其重新发起 Pull Request。
The commit email domain belongs to one of our partners, but it seems you are not yet a member of the current organization, please contact the contact person to add you to the organization or let them submit the Pull Request.

You can retrigger this bot by commenting recheck in this Pull Request

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @wjyrich - I've reviewed your changes - here's some feedback:

  • Consider separating the XML declaration updates and translation tag formatting in .ts files into a distinct pull request to focus this PR on the quotation mark fix.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented May 8, 2025

Reviewer's Guide

This pull request implements the addition of quotation marks around the application name in the uninstall confirmation dialog. This is achieved by directly modifying the translatable string in two QML files (Main.qml and launcheritem.qml) to include escaped quotes. Consequently, all translation (.ts) files were updated to reflect this new string, mark the previous version as obsolete, and apply minor XML formatting changes such as specifying UTF-8 encoding and standardizing empty translation tags.

File-Level Changes

Change Details Files
Enclosed the app name with quotation marks in the uninstall dialog's source string.
  • Updated the qsTr call to include escaped quotes around the %1 placeholder for the app name.
qml/Main.qml
shell-launcher-applet/package/launcheritem.qml
Updated translation files for the modified uninstall string and related formatting.
  • Added new translatable source string Are you sure you want to uninstall "%1"?.
  • Marked old source string Are you sure you want to uninstall %1? as vanished.
  • Updated XML declaration to include encoding="utf-8".
  • Standardized empty <translation> tags to use separate start and end tags.
  • Updated line numbers in <location> tags for various existing translations, reflecting changes in QML source files.
shell-launcher-applet/translations/org.deepin.ds.dock.launcherapplet_az.ts
shell-launcher-applet/translations/org.deepin.ds.dock.launcherapplet_ru.ts
shell-launcher-applet/translations/org.deepin.ds.dock.launcherapplet_fr.ts
shell-launcher-applet/translations/org.deepin.ds.dock.launcherapplet_zh_HK.ts
shell-launcher-applet/translations/org.deepin.ds.dock.launcherapplet_zh_TW.ts
shell-launcher-applet/translations/org.deepin.ds.dock.launcherapplet_ca.ts
shell-launcher-applet/translations/org.deepin.ds.dock.launcherapplet_es.ts
shell-launcher-applet/translations/org.deepin.ds.dock.launcherapplet_fi.ts
shell-launcher-applet/translations/org.deepin.ds.dock.launcherapplet_hu.ts
shell-launcher-applet/translations/org.deepin.ds.dock.launcherapplet_ja.ts
shell-launcher-applet/translations/org.deepin.ds.dock.launcherapplet_pl.ts
shell-launcher-applet/translations/org.deepin.ds.dock.launcherapplet_pt_BR.ts
shell-launcher-applet/translations/org.deepin.ds.dock.launcherapplet_uk.ts
shell-launcher-applet/translations/org.deepin.ds.dock.launcherapplet_zh_CN.ts
shell-launcher-applet/translations/org.deepin.ds.dock.launcherapplet.ts
shell-launcher-applet/translations/org.deepin.ds.dock.launcherapplet_bo.ts
shell-launcher-applet/translations/org.deepin.ds.dock.launcherapplet_it.ts
shell-launcher-applet/translations/org.deepin.ds.dock.launcherapplet_ko.ts
shell-launcher-applet/translations/org.deepin.ds.dock.launcherapplet_nb_NO.ts
translations/dde-launchpad_ca.ts
translations/dde-launchpad_es.ts
translations/dde-launchpad_fi.ts
translations/dde-launchpad_fr.ts
translations/dde-launchpad_hu.ts
translations/dde-launchpad_ja.ts
translations/dde-launchpad_pl.ts
translations/dde-launchpad_pt_BR.ts
translations/dde-launchpad_ru.ts
translations/dde-launchpad_uk.ts
translations/dde-launchpad_zh_CN.ts
translations/dde-launchpad_zh_HK.ts
translations/dde-launchpad_zh_TW.ts
translations/dde-launchpad.ts
translations/dde-launchpad_az.ts
translations/dde-launchpad_bo.ts
translations/dde-launchpad_it.ts
translations/dde-launchpad_ko.ts
translations/dde-launchpad_nb_NO.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, wjyrich

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia BLumia merged commit fe4b7e6 into linuxdeepin:master May 8, 2025
6 of 10 checks passed
@wjyrich wjyrich deleted the fix-bug-315259 branch June 6, 2025 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants