fix: Add quotation marks to the app name in the uninstall dialog#550
Conversation
add "" for app uninstall pms-bug-315259
|
CLA Assistant Lite bot: |
There was a problem hiding this comment.
Hey @wjyrich - I've reviewed your changes - here's some feedback:
- Consider separating the XML declaration updates and translation tag formatting in
.tsfiles into a distinct pull request to focus this PR on the quotation mark fix.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Reviewer's GuideThis pull request implements the addition of quotation marks around the application name in the uninstall confirmation dialog. This is achieved by directly modifying the translatable string in two QML files ( File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BLumia, wjyrich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
add "" for app uninstall
pms-bug-315259
Summary by Sourcery
Bug Fixes: