fix: Clicking tab multiple times to switch focus appear to switch ba…

[wjyrich]

…ck and forth

fix tab Btn with focus

pms-bug-315227

Summary by Sourcery

Fix tab navigation behavior in the application list view by adjusting focus and key navigation properties

Bug Fixes:

• Resolved issue with tab navigation switching focus inconsistently in the app list view

Enhancements:

• Simplified key navigation configuration for app list items

[deepin-ci-robot]

deepin pr auto review

关键摘要:

• 在AppList.qml文件中，将nextKeyTabTargetItem属性更改为KeyNavigation.tab，这是一个合理的更改，因为它更符合QML的导航规则。
• 在AppListView.qml文件中，删除了nextKeyTabTargetItem属性和activeFocusOnTab属性，这可能是为了简化代码或修复特定问题。需要确认这些更改是否与整体设计意图一致。

是否建议立即修改:

• 是，需要确认AppListView.qml中的更改是否正确，并且这些更改不会影响其他功能。如果这些更改是必要的，应该立即进行修改并添加相应的注释说明。

[sourcery-ai]

Reviewer's Guide

This pull request fixes incorrect tab focus switching by removing internal tab handling logic (activeFocusOnTab and a custom nextKeyTabTargetItem property) from AppListView.qml and instead explicitly setting the KeyNavigation.tab property on the AppListView instance within AppList.qml.

File-Level Changes

Change	Details	Files
Removed internal tab navigation properties and bindings.	Removed nextKeyTabTargetItem property. Removed KeyNavigation.tab binding from delegate. Removed activeFocusOnTab property from listView.	qml/windowed/AppListView.qml
Set explicit tab navigation target.	Replaced nextKeyTabTargetItem binding with KeyNavigation.tab on the AppListView instance.	qml/windowed/AppList.qml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @wjyrich - I've reviewed your changes - here's some feedback:

• This PR modifies focus handling by removing activeFocusOnTab and adjusting KeyNavigation.tab; ensure the intended focus target within AppListView (e.g., the view vs. its items) is preserved.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, wjyrich

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment