Skip to content

fix: Add quotation marks to the app name in the uninstall dialog #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BLumia merged 1 commit into from
May 8, 2025
Merged

fix: Add quotation marks to the app name in the uninstall dialog #550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion qml/Main.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ QtObject {
spacing: 0
Label {
font: DTK.fontManager.t5
text: qsTr("Are you sure you want to uninstall %1?").arg(confirmUninstallDlg.appName)
text: qsTr("Are you sure you want to uninstall \"%1\"?").arg(confirmUninstallDlg.appName)
wrapMode: Text.Wrap
horizontalAlignment: Text.AlignHCenter
Layout.preferredWidth: 400
Expand Down
2 changes: 1 addition & 1 deletion shell-launcher-applet/package/launcheritem.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ AppletItem {
spacing: 0
Label {
font: DTK.fontManager.t5
text: qsTr("Are you sure you want to uninstall %1?").arg(confirmUninstallDlg.appName)
text: qsTr("Are you sure you want to uninstall \"%1\"?").arg(confirmUninstallDlg.appName)
wrapMode: Text.Wrap
horizontalAlignment: Text.AlignHCenter
Layout.preferredWidth: 400
Expand Down
14 changes: 7 additions & 7 deletions shell-launcher-applet/translations/org.deepin.ds.dock.launcherapplet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@
<context>
<name>FullscreenFrame</name>
<message>
<location filename="../../qml/FullscreenFrame.qml" line="163"/>
<location filename="../../qml/FullscreenFrame.qml" line="254"/>
<source>Window Mode</source>
<translation type="unfinished"></translation>
</message>
Expand Down Expand Up @@ -180,7 +180,7 @@
</message>
<message>
<location filename="../../qml/Main.qml" line="400"/>
<source>Are you sure you want to uninstall %1?</source>
<source>Are you sure you want to uninstall &quot;%1&quot;?</source>
<translation type="unfinished"></translation>
</message>
<message>
Expand Down Expand Up @@ -210,7 +210,7 @@
<translation type="unfinished"></translation>
</message>
<message>
<location filename="../../qml/FullscreenFrame.qml" line="556"/>
<location filename="../../qml/FullscreenFrame.qml" line="557"/>
<location filename="../../qml/windowed/SearchResultView.qml" line="102"/>
<source>No search results</source>
<translation type="unfinished"></translation>
Expand Down Expand Up @@ -327,17 +327,17 @@
<translation type="unfinished"></translation>
</message>
<message>
<location filename="../package/launcheritem.qml" line="299"/>
<source>Are you sure you want to uninstall %1?</source>
<location filename="../package/launcheritem.qml" line="309"/>
<source>Are you sure you want to uninstall &quot;%1&quot;?</source>
<translation type="unfinished"></translation>
</message>
<message>
<location filename="../package/launcheritem.qml" line="311"/>
<location filename="../package/launcheritem.qml" line="321"/>
<source>Cancel</source>
<translation type="unfinished"></translation>
</message>
<message>
<location filename="../package/launcheritem.qml" line="325"/>
<location filename="../package/launcheritem.qml" line="335"/>
<source>Confirm</source>
<translation type="unfinished"></translation>
</message>
Expand Down
68 changes: 39 additions & 29 deletions shell-launcher-applet/translations/org.deepin.ds.dock.launcherapplet_az.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
<?xml version="1.0" ?><!DOCTYPE TS><TS version="2.1" language="az">
<?xml version="1.0" encoding="utf-8"?>
<!DOCTYPE TS>
<TS version="2.1" language="az">
<context>
<name>AppItemMenu</name>
<message>
Expand Down Expand Up @@ -77,12 +79,12 @@
<message>
<location filename="../../qml/windowed/BottomBar.qml" line="33"/>
<source>Power</source>
<translation type="unfinished"/>
<translation type="unfinished"></translation>
</message>
<message>
<location filename="../../qml/windowed/BottomBar.qml" line="62"/>
<source>Search</source>
<translation type="unfinished"/>
<translation type="unfinished"></translation>
</message>
<message>
<location filename="../../qml/windowed/BottomBar.qml" line="109"/>
Expand Down Expand Up @@ -114,7 +116,7 @@
<context>
<name>FullscreenFrame</name>
<message>
<location filename="../../qml/FullscreenFrame.qml" line="163"/>
<location filename="../../qml/FullscreenFrame.qml" line="254"/>
<source>Window Mode</source>
<translation>Pencərə rejimi</translation>
</message>
Expand All @@ -124,27 +126,27 @@
<message>
<location filename="../../qml/Main.qml" line="22"/>
<source>Internet</source>
<translation type="unfinished"/>
<translation type="unfinished"></translation>
</message>
<message>
<location filename="../../qml/Main.qml" line="24"/>
<source>Chat</source>
<translation type="unfinished"/>
<translation type="unfinished"></translation>
</message>
<message>
<location filename="../../qml/Main.qml" line="26"/>
<source>Music</source>
<translation type="unfinished"/>
<translation type="unfinished"></translation>
</message>
<message>
<location filename="../../qml/Main.qml" line="28"/>
<source>Video</source>
<translation type="unfinished"/>
<translation type="unfinished"></translation>
</message>
<message>
<location filename="../../qml/Main.qml" line="30"/>
<source>Graphics</source>
<translation type="unfinished"/>
<translation type="unfinished"></translation>
</message>
<message>
<location filename="../../qml/Main.qml" line="32"/>
Expand All @@ -154,22 +156,22 @@
<message>
<location filename="../../qml/Main.qml" line="34"/>
<source>Office</source>
<translation type="unfinished"/>
<translation type="unfinished"></translation>
</message>
<message>
<location filename="../../qml/Main.qml" line="36"/>
<source>Reading</source>
<translation type="unfinished"/>
<translation type="unfinished"></translation>
</message>
<message>
<location filename="../../qml/Main.qml" line="38"/>
<source>Development</source>
<translation type="unfinished"/>
<translation type="unfinished"></translation>
</message>
<message>
<location filename="../../qml/Main.qml" line="40"/>
<source>System</source>
<translation type="unfinished"/>
<translation type="unfinished"></translation>
</message>
<message>
<location filename="../../qml/Main.qml" line="42"/>
Expand All @@ -178,8 +180,12 @@
</message>
<message>
<location filename="../../qml/Main.qml" line="400"/>
<source>Are you sure you want to uninstall &quot;%1&quot;?</source>
<translation type="unfinished"></translation>
</message>
<message>
<source>Are you sure you want to uninstall %1?</source>
<translation>%1 cıxartmaq istəyirsiniz?
<translation type="vanished">%1 cıxartmaq istəyirsiniz?
</translation>
</message>
<message>
Expand Down Expand Up @@ -209,7 +215,7 @@
<translation>Bütün uquanlar</translation>
</message>
<message>
<location filename="../../qml/FullscreenFrame.qml" line="556"/>
<location filename="../../qml/FullscreenFrame.qml" line="557"/>
<location filename="../../qml/windowed/SearchResultView.qml" line="102"/>
<source>No search results</source>
<translation>Axtarış nəticəsi tapılmadı</translation>
Expand Down Expand Up @@ -268,27 +274,27 @@
<message>
<location filename="../package/launcheritem.qml" line="111"/>
<source>Internet</source>
<translation type="unfinished"/>
<translation type="unfinished"></translation>
</message>
<message>
<location filename="../package/launcheritem.qml" line="113"/>
<source>Chat</source>
<translation type="unfinished"/>
<translation type="unfinished"></translation>
</message>
<message>
<location filename="../package/launcheritem.qml" line="115"/>
<source>Music</source>
<translation type="unfinished"/>
<translation type="unfinished"></translation>
</message>
<message>
<location filename="../package/launcheritem.qml" line="117"/>
<source>Video</source>
<translation type="unfinished"/>
<translation type="unfinished"></translation>
</message>
<message>
<location filename="../package/launcheritem.qml" line="119"/>
<source>Graphics</source>
<translation type="unfinished"/>
<translation type="unfinished"></translation>
</message>
<message>
<location filename="../package/launcheritem.qml" line="121"/>
Expand All @@ -298,22 +304,22 @@
<message>
<location filename="../package/launcheritem.qml" line="123"/>
<source>Office</source>
<translation type="unfinished"/>
<translation type="unfinished"></translation>
</message>
<message>
<location filename="../package/launcheritem.qml" line="125"/>
<source>Reading</source>
<translation type="unfinished"/>
<translation type="unfinished"></translation>
</message>
<message>
<location filename="../package/launcheritem.qml" line="127"/>
<source>Development</source>
<translation type="unfinished"/>
<translation type="unfinished"></translation>
</message>
<message>
<location filename="../package/launcheritem.qml" line="129"/>
<source>System</source>
<translation type="unfinished"/>
<translation type="unfinished"></translation>
</message>
<message>
<location filename="../package/launcheritem.qml" line="131"/>
Expand All @@ -326,20 +332,24 @@
<translation>launchpad</translation>
</message>
<message>
<location filename="../package/launcheritem.qml" line="299"/>
<location filename="../package/launcheritem.qml" line="309"/>
<source>Are you sure you want to uninstall &quot;%1&quot;?</source>
<translation type="unfinished"></translation>
</message>
<message>
<source>Are you sure you want to uninstall %1?</source>
<translation>%1 cıxış etmək istəyirsiniz?
<translation type="vanished">%1 cıxış etmək istəyirsiniz?
</translation>
</message>
<message>
<location filename="../package/launcheritem.qml" line="311"/>
<location filename="../package/launcheritem.qml" line="321"/>
<source>Cancel</source>
<translation>İptal</translation>
</message>
<message>
<location filename="../package/launcheritem.qml" line="325"/>
<location filename="../package/launcheritem.qml" line="335"/>
<source>Confirm</source>
<translation>Təsdiq et</translation>
</message>
</context>
</TS>
</TS>
14 changes: 7 additions & 7 deletions shell-launcher-applet/translations/org.deepin.ds.dock.launcherapplet_bo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@
<translation type="obsolete">བཤེར་འཚོལ།</translation>
</message>
<message>
<location filename="../../qml/FullscreenFrame.qml" line="163"/>
<location filename="../../qml/FullscreenFrame.qml" line="254"/>
<source>Window Mode</source>
<translation type="unfinished"></translation>
</message>
Expand Down Expand Up @@ -223,7 +223,7 @@
</message>
<message>
<location filename="../../qml/Main.qml" line="400"/>
<source>Are you sure you want to uninstall %1?</source>
<source>Are you sure you want to uninstall &quot;%1&quot;?</source>
<translation type="unfinished"></translation>
</message>
<message>
Expand Down Expand Up @@ -253,7 +253,7 @@
<translation type="unfinished"></translation>
</message>
<message>
<location filename="../../qml/FullscreenFrame.qml" line="556"/>
<location filename="../../qml/FullscreenFrame.qml" line="557"/>
<location filename="../../qml/windowed/SearchResultView.qml" line="102"/>
<source>No search results</source>
<translation type="unfinished"></translation>
Expand Down Expand Up @@ -385,17 +385,17 @@
<translation type="unfinished"></translation>
</message>
<message>
<location filename="../package/launcheritem.qml" line="299"/>
<source>Are you sure you want to uninstall %1?</source>
<location filename="../package/launcheritem.qml" line="309"/>
<source>Are you sure you want to uninstall &quot;%1&quot;?</source>
<translation type="unfinished"></translation>
</message>
<message>
<location filename="../package/launcheritem.qml" line="311"/>
<location filename="../package/launcheritem.qml" line="321"/>
<source>Cancel</source>
<translation type="unfinished"></translation>
</message>
<message>
<location filename="../package/launcheritem.qml" line="325"/>
<location filename="../package/launcheritem.qml" line="335"/>
<source>Confirm</source>
<translation type="unfinished"></translation>
</message>
Expand Down
28 changes: 19 additions & 9 deletions shell-launcher-applet/translations/org.deepin.ds.dock.launcherapplet_ca.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
<?xml version="1.0" ?><!DOCTYPE TS><TS version="2.1" language="ca">
<?xml version="1.0" encoding="utf-8"?>
<!DOCTYPE TS>
<TS version="2.1" language="ca">
<context>
<name>AppItemMenu</name>
<message>
Expand Down Expand Up @@ -114,7 +116,7 @@
<context>
<name>FullscreenFrame</name>
<message>
<location filename="../../qml/FullscreenFrame.qml" line="163"/>
<location filename="../../qml/FullscreenFrame.qml" line="254"/>
<source>Window Mode</source>
<translation>Mode de finestra</translation>
</message>
Expand Down Expand Up @@ -178,8 +180,12 @@
</message>
<message>
<location filename="../../qml/Main.qml" line="400"/>
<source>Are you sure you want to uninstall &quot;%1&quot;?</source>
<translation type="unfinished"></translation>
</message>
<message>
<source>Are you sure you want to uninstall %1?</source>
<translation>Segur que voleu desinstal·lar %1?</translation>
<translation type="vanished">Segur que voleu desinstal·lar %1?</translation>
</message>
<message>
<location filename="../../qml/Main.qml" line="412"/>
Expand Down Expand Up @@ -208,7 +214,7 @@
<translation>Totes les aplicacions</translation>
</message>
<message>
<location filename="../../qml/FullscreenFrame.qml" line="556"/>
<location filename="../../qml/FullscreenFrame.qml" line="557"/>
<location filename="../../qml/windowed/SearchResultView.qml" line="102"/>
<source>No search results</source>
<translation>No hi ha resultats de la cerca.</translation>
Expand Down Expand Up @@ -325,19 +331,23 @@
<translation>plataforma de llançament</translation>
</message>
<message>
<location filename="../package/launcheritem.qml" line="299"/>
<location filename="../package/launcheritem.qml" line="309"/>
<source>Are you sure you want to uninstall &quot;%1&quot;?</source>
<translation type="unfinished"></translation>
</message>
<message>
<source>Are you sure you want to uninstall %1?</source>
<translation>Segur que voleu desinstal·lar %1?</translation>
<translation type="vanished">Segur que voleu desinstal·lar %1?</translation>
</message>
<message>
<location filename="../package/launcheritem.qml" line="311"/>
<location filename="../package/launcheritem.qml" line="321"/>
<source>Cancel</source>
<translation>Cancel·la</translation>
</message>
<message>
<location filename="../package/launcheritem.qml" line="325"/>
<location filename="../package/launcheritem.qml" line="335"/>
<source>Confirm</source>
<translation>Confirmeu-ho</translation>
</message>
</context>
</TS>
</TS>
Loading
Loading