Skip to content

fix: cancel hovered state after move mouse in the categorized display.#555

Merged
BLumia merged 1 commit into
linuxdeepin:masterfrom
wjyrich:fix-bug-271375
May 9, 2025
Merged

fix: cancel hovered state after move mouse in the categorized display.#555
BLumia merged 1 commit into
linuxdeepin:masterfrom
wjyrich:fix-bug-271375

Conversation

@wjyrich
Copy link
Copy Markdown
Contributor

@wjyrich wjyrich commented May 9, 2025

as title.

pms-bug-271375

Summary by Sourcery

Bug Fixes:

  • Corrected the hover state rendering in the app list view to properly show background highlight

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @wjyrich - I've reviewed your changes - here's some feedback:

  • Please verify this change doesn't unintentionally remove a visual indicator for keyboard focus, if highlighted was serving that purpose for menuItem.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, wjyrich

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia BLumia merged commit 46e4d3d into linuxdeepin:master May 9, 2025
7 of 10 checks passed
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented May 9, 2025

Reviewer's Guide

This pull request updates the visibility logic for a UI element in AppListView.qml. The implementation involved changing the QML binding for a component's visible property, replacing menuItem.highlighted with menuItem.hovered to ensure its visibility accurately reflects the mouse hover state.

File-Level Changes

Change Details Files
Corrected UI element visibility to depend on hover state instead of highlight state.
  • Modified the visible property binding to use menuItem.hovered instead of menuItem.highlighted for a UI element within a list item component.
qml/windowed/AppListView.qml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@wjyrich wjyrich deleted the fix-bug-271375 branch June 6, 2025 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants