Revert "feat: Add fuzzy search support for applications"#560
Conversation
This reverts commit 8e2bca7.
deepin pr auto review关键摘要:
是否建议立即修改:
|
There was a problem hiding this comment.
Hey @wjyrich - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| const QString & displayName = modelIndex.data(Qt::DisplayRole).toString(); | ||
| const QString & name = modelIndex.data(AppsModel::NameRole).toString(); | ||
| const QString & transliterated = modelIndex.data(AppsModel::AllTransliteratedRole).toString(); | ||
| const QString & jianpin = Dtk::Core::firstLetters(displayName).join(','); |
There was a problem hiding this comment.
suggestion (bug_risk): Using join(',') inserts commas between initials and may break substring matching
Use join("") instead of join(",") to concatenate initials without commas so contains() works as expected.
| const QString & jianpin = Dtk::Core::firstLetters(displayName).join(','); | |
| // concatenate initials without commas so contains() works correctly | |
| const QString jianpin = Dtk::Core::firstLetters(displayName).join(QString()); |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BLumia, wjyrich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's GuideThis PR reverts the previously added fuzzy search feature by removing the fuzzyMatch implementation and simplifying the row filtering logic to use basic substring checks and jianpin matching. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This reverts commit 8e2bca7.
Summary by Sourcery
Revert fuzzy search support and simplify search filter logic to use direct substring matching across multiple name representations.
Enhancements:
Chores: