feat: add Support for acronym matching and others.#569
Conversation
Reviewer's GuideEnhanced filterAcceptsRow to support acronym matching via uppercase initials, numeric-prefix matching, and restricted startsWith matching for pure lowercase English names while preserving existing fuzzy search across name variants. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @wjyrich - I've reviewed your changes - here's some feedback:
- The numeric-matching block only checks digits in displayName but ignores other name variants (nameCopy, transliterated, jianpin); consider extending number-prefix logic to all fields for consistency.
- Acronym logic only captures uppercase initials—if you want to support lowercase or mixed-case acronyms, adjust the word[0].isUpper() check or normalize all initials.
- There’s a lot of repeated startsWith/contains logic between the English-only and fallback branches; extract a helper function to dedupe and clarify the matching rules.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
490d7ab to
d27284c
Compare
a7ef785 to
72ae48f
Compare
add Support for acronym matching, add Intermediate matching is not supported for lowercase letters. Log:
deepin pr auto review代码审查意见:
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BLumia, wjyrich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
add Support for acronym matching,
add Intermediate matching is not supported for lowercase letters.
Log:
Summary by Sourcery
Refine the search filter logic to support acronym-based lookups, enforce prefix matching for lowercase names, and handle numeric-only display names separately while retaining existing matching behavior for other cases.
New Features:
Enhancements: