Skip to content

fix: Search adjustments are the same color as other text icons#571

Merged
deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
wjyrich:fix-bug-314401
May 23, 2025
Merged

fix: Search adjustments are the same color as other text icons#571
deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
wjyrich:fix-bug-314401

Conversation

@wjyrich
Copy link
Copy Markdown
Contributor

@wjyrich wjyrich commented May 23, 2025

as title

PMS-BUG-314401

Summary by Sourcery

Use the default button text color for the search edit component to ensure its icons and placeholder text match other text icons throughout the UI

Bug Fixes:

  • Align search field icons and text with other text icons by using DStyle.Style.button.text color

Enhancements:

  • Remove custom iconPalette configuration from SearchEdit and switch ColorSelector to use the common text color

@deepin-ci-robot
Copy link
Copy Markdown

deepin pr auto review

关键摘要:

  • 移除了iconPalette属性的定义,可能会影响图标颜色在不同主题下的显示
  • 新增了ColorSelector.pressed属性,但未提供其定义和用途
  • placeholderTextColorpalette.windowText属性都使用了ColorSelector.textColor,可能需要确认这是否是预期的行为

是否建议立即修改:

  • 是,需要确认移除iconPalette属性的影响,并确保新增的ColorSelector.pressed属性有明确的定义和用途
  • 是,需要验证placeholderTextColorpalette.windowText属性使用ColorSelector.textColor的合理性,并确保这一改动符合设计要求

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented May 23, 2025

Reviewer's Guide

This PR refactors the SearchEdit in BottomBar.qml to use the centralized DStyle button text palette, removing custom color definitions and aligning search text and icon colors with other toolbar icons.

Sequence Diagram: SearchEdit Color Sourcing from DStyle

sequenceDiagram
    participant SE as SearchEdit
    participant DS as "DStyle.Style.button"

    SE->>DS: Request 'text' palette for styling
    activate DS
    DS-->>SE: Provide 'text' palette
    deactivate DS
    SE->>SE: Configure self (text, placeholder, icon colors) using received palette
Loading

Class Diagram: Changes to SearchEdit Properties

classDiagram
    class SearchEdit {
        -iconPalette: Palette
        +textColor: Palette
        placeholderTextColor: Color
        palette.windowText: Color
        ColorSelector.pressed: Boolean
    }
Loading

File-Level Changes

Change Details Files
Imported the standard button text style from org.deepin.dtk.style
  • Added import alias for org.deepin.dtk.style as DStyle
qml/windowed/BottomBar.qml
Removed custom Palette definitions and hardcoded colors
  • Deleted the property Palette iconPalette block
  • Removed custom placeholderTextColor: palette.brightText
  • Removed custom palette.windowText binding to ColorSelector.iconPalette
qml/windowed/BottomBar.qml
Replaced custom colors with DStyle.Style.button.text and disabled pressed state
  • Added property Palette textColor referencing DStyle.Style.button.text
  • Updated placeholderTextColor and palette.windowText to use ColorSelector.textColor
  • Set ColorSelector.pressed to false
qml/windowed/BottomBar.qml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @wjyrich - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, wjyrich

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wjyrich
Copy link
Copy Markdown
Contributor Author

wjyrich commented May 23, 2025

/forcemerge

@deepin-bot
Copy link
Copy Markdown

deepin-bot Bot commented May 23, 2025

This pr force merged! (status: behind)

@deepin-bot deepin-bot Bot merged commit 3fbd2e9 into linuxdeepin:master May 23, 2025
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants