Skip to content

feat: Added left and right button switching in full-screen mode.#575

Merged
deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
wjyrich:fix-bug-289119
Jun 11, 2025
Merged

feat: Added left and right button switching in full-screen mode.#575
deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
wjyrich:fix-bug-289119

Conversation

@wjyrich
Copy link
Copy Markdown
Contributor

@wjyrich wjyrich commented Jun 11, 2025

Also fix bug, when first open launchpad, open show focus in first app.

PMS-BUG-289119

Also fix bug, when first open launchpad, open show focus in first app.

PMS-BUG-289119
@deepin-ci-robot
Copy link
Copy Markdown

deepin pr auto review

关键摘要:

  • FullscreenFrame.qml中,使用Qt.callLater延迟更新previousIndex可能会导致界面更新延迟,需要确认是否有必要延迟处理。
  • FullscreenFrame.qml中,Keys.onRightPressed逻辑将最后一个页面跳转到第一个页面,这可能不是预期的行为,需要确认是否正确处理了用户意图。
  • GridViewContainer.qml中,移除了处理键盘事件的代码,如果这部分代码是必要的,应该重新添加并确保其正确性。

是否建议立即修改:

  • 是,特别是关于FullscreenFrame.qml中的Keys.onRightPressed逻辑,需要确认其是否符合预期行为。
  • 是,如果GridViewContainer.qml中的键盘事件处理代码是必要的,应该立即恢复并确保其正确性。

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, wjyrich

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wjyrich
Copy link
Copy Markdown
Contributor Author

wjyrich commented Jun 11, 2025

/forcemerge

@deepin-bot deepin-bot Bot merged commit 67784c6 into linuxdeepin:master Jun 11, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants