fix: adjust WindowedFrame layout width#645
Merged
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusted the Layout.preferredWidth in WindowedFrame.qml from 362 to 365 to resolve UI alignment issues and ensure visual consistency without altering the overall layout structure. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
robertkill
approved these changes
Aug 22, 2025
BLumia
approved these changes
Aug 22, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BLumia, robertkill, wjyrich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Changed Layout.preferredWidth from 362 to 365 to fix layout alignment issues This minor width adjustment ensures proper UI element positioning and prevents visual glitches The change maintains the overall layout structure while improving visual consistency fix: 调整 WindowedFrame 布局宽度 将 Layout.preferredWidth 从 362 改为 365 以修复布局对齐问题 这个微小的宽度调整确保了 UI 元素的正确位置并防止视觉瑕疵 该更改保持了整体布局结构同时提高了视觉一致性 Pms: BUG-330553
1827d12 to
849d710
Compare
deepin pr auto review我来审查这个代码变更: 这是一个简单的QML文件中的布局宽度调整变更,将
改进建议:
// 将宽度从362增加到365以适应新的设计规范
Layout.preferredWidth: 365
// 建议在Constants.js中定义标准宽度
Layout.preferredWidth: Constants.standardWidth
Layout.preferredWidth: 365
Layout.minimumWidth: 360
Layout.maximumWidth: 370总的来说,这个变更本身很简单且安全,但为了提高代码质量和可维护性,建议采用上述改进措施。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed Layout.preferredWidth from 362 to 365 to fix layout alignment issues
This minor width adjustment ensures proper UI element positioning and prevents visual glitches
The change maintains the overall layout structure while improving visual consistency
fix: 调整 WindowedFrame 布局宽度
将 Layout.preferredWidth 从 362 改为 365 以修复布局对齐问题
这个微小的宽度调整确保了 UI 元素的正确位置并防止视觉瑕疵
该更改保持了整体布局结构同时提高了视觉一致性
Pms: BUG-330553
Summary by Sourcery
Bug Fixes: