fix: ensure remove tone for pinyin first letter search#656
Merged
Conversation
确保简拼获取时没有音调. PMS: BUG-333411 Log:
deepin pr auto review我来对这次代码变更进行审查:
改进建议:
总体而言,这次变更主要是为了适应依赖库的更新,并增加了相应的测试用例。变更本身是合理的,但建议关注上述提到的改进点,以提高代码的健壮性和性能。 |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdate pinyin initial extraction to strip tone marks and extend tests to verify tone-less initials for the new 'defender' item. Class diagram for updated pinyin initial extraction in SearchFilterProxyModelclassDiagram
class SearchFilterProxyModel {
+calculateWeight(modelIndex: QModelIndex) : int
}
class Dtk::Core {
+firstLetters(text: QString, toneOption: ToneOption) : QStringList
}
SearchFilterProxyModel --> Dtk::Core: uses
class ToneOption {
<<enumeration>>
TS_NoneTone
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
18202781743
approved these changes
Oct 10, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
确保简拼获取时没有音调.
Summary by Sourcery
Ensure pinyin initials are generated without tone for first-letter searches and add a test case for the '安全中心' app to validate the change
Bug Fixes:
Tests: