chore: adapt debugging settings function#667
Merged
Merged
Conversation
Using linuxdeepin/dde-control-center f86903a87b52048189d0d869c1828fc13da28c03 as reference. Log:
deepin pr auto review我来对这次代码变更进行审查:
# 建议使用变量来存储路径,提高可维护性
set(DEBUG_CONFIG_DIR ${CMAKE_INSTALL_DATADIR}/deepin-debug-config/deepin-debug-config.d)
set(LOG_CONFIG_DIR ${CMAKE_INSTALL_DATADIR}/deepin-log-viewer/deepin-log.conf.d)
install(FILES ${CMAKE_SOURCE_DIR}/dist/deepin-debug-config/org.deepin.dde.launchpad.json
DESTINATION ${DEBUG_CONFIG_DIR})
install(FILES ${CMAKE_SOURCE_DIR}/dist/deepin-log-config/org.deepin.dde.launchpad.json
DESTINATION ${LOG_CONFIG_DIR})b) 日志配置文件优化:
c) 日志分类管理:
总体来说,这次变更是一个积极的改进,提高了代码的可维护性和调试能力。建议的改进主要集中在配置管理和代码组织方面,这些改进将使代码更加健壮和易于维护。 |
18202781743
approved these changes
Nov 11, 2025
wjyrich
approved these changes
Nov 11, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia, wjyrich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using linuxdeepin/dde-control-center f86903a87b52048189d0d869c1828fc13da28c03 as reference.
Log: