fix: Fix issue with icon drag-and-drop release failure

[pengfeixx]

Fix issue with icon drag-and-drop release failure

Log: Fix issue with icon drag-and-drop release failure
pms: BUG-344221

Summary by Sourcery

Bug Fixes:

• Ensure drag-and-drop releases over folder pages are correctly handled even when previously interpreted as page-boundary drops.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Ensures that icon drag-and-drop always processes the drop target page, even when the drag ends over page boundaries, by removing an early-return boundary check and always invoking the page drop handler before resetting pagination state.

Sequence diagram for updated icon drag-and-drop drop handling

sequenceDiagram
    actor User
    participant FolderGridViewPopup
    participant DropEvent
    participant FolderPagesView
    participant FolderController

    User->>FolderGridViewPopup: drag icon
    User->>FolderGridViewPopup: release icon over page boundary
    FolderGridViewPopup->>DropEvent: onDropped(drop)
    DropEvent-->>FolderGridViewPopup: getDataAsString(text/x-dde-launcher-dnd-desktopId)
    FolderGridViewPopup->>FolderController: dropOnPage(dragId, internal/folders/currentFolderId, currentIndex)
    FolderGridViewPopup->>FolderGridViewPopup: pageIntent = 0
    FolderGridViewPopup->>FolderGridViewPopup: createdEmptyPage = false
    FolderGridViewPopup-->>User: icon positioned on target page

Loading

File-Level Changes

Change	Details	Files
Always perform drop handling for icon drag-and-drop regardless of page boundary state.	Removed conditional early return that skipped drop handling when a page boundary intent was active. Kept retrieval of the drag payload ID from the drop event and immediately passed it to the page drop handler. Reset pagination and empty-page state after processing the drop to maintain existing navigation behavior.	qml/FolderGridViewPopup.qml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The previous guard that ignored drops when pageIntent !== 0 has been removed; consider whether this reintroduces unwanted drops when dragging across page boundaries and, if needed, restore a more targeted condition instead of removing it entirely.
• The new let dragId line introduces trailing whitespace; remove it to keep the QML file clean and consistent with surrounding style.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The previous guard that ignored drops when `pageIntent !== 0` has been removed; consider whether this reintroduces unwanted drops when dragging across page boundaries and, if needed, restore a more targeted condition instead of removing it entirely.
- The new `let dragId` line introduces trailing whitespace; remove it to keep the QML file clean and consistent with surrounding style.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deepin-ci-robot]

deepin pr auto review

我来帮你审查这段代码变更。这是一个QML文件中的拖放功能修改，主要涉及文件夹网格视图的拖放处理逻辑。

1. 代码逻辑分析：
   原代码在onDropped事件处理中，当拖动到页面边界时(pageIntent !== 0)会直接返回不做处理。修改后的代码移除了这个边界检查，而是直接执行drop操作。

2. 潜在问题：

• 代码注释提到"Boundary release requires responsive movement"，但这个修改可能会导致边界拖放行为异常
• 移除边界检查可能会影响用户体验，因为用户可能需要在边界处取消拖放操作
• 没有对dragId进行有效性验证，可能导致空值或无效ID被处理

3. 改进建议：

onDropped: (drop) => {
    // 保留边界检查，但增加响应性
    if (pageIntent !== 0) {
        // 添加边界释放的动画效果
        boundaryAnimation.start()
        pageIntent = 0
        return
    }
    
    // 验证拖放数据有效性
    let dragId = drop.getDataAsString("text/x-dde-launcher-dnd-desktopId")
    if (!dragId || dragId.trim() === "") {
        console.warn("Invalid drag ID received")
        return
    }
    
    // 执行拖放操作
    dropOnPage(dragId, "internal/folders/" + folderLoader.currentFolderId, folderPagesView.currentIndex)
    pageIntent = 0
}

// 添加边界释放动画
PropertyAnimation {
    id: boundaryAnimation
    target: folderPagesView
    property: "contentX"
    duration: 200
    easing.type: Easing.OutQuad
}

4. 安全性考虑：

• 添加了对dragId的验证，防止无效数据导致的问题
• 保留了边界检查机制，避免意外操作
• 添加了动画反馈，提升用户体验

5. 性能优化：

• 动画使用硬件加速的PropertyAnimation
• 提前返回避免不必要的计算
• 使用trim()处理可能的空格字符

这个修改建议既保持了原有的边界检查功能，又增加了响应性和安全性。建议在实现时根据实际需求调整动画参数和验证逻辑。

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, pengfeixx

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment