feat: set fullscreen launcher window title for window manager identification#696
Merged
Merged
Conversation
identification Changed the window title of the fullscreen launcher frame from "Fullscreen Launchpad" to "org.deepin.ds.launchpad.fullscreen". This modification sets the X window property _NET_WM_NAME to a standardized identifier, allowing window managers to easily distinguish dde-shell application windows from other windows in the system. Log: Set fullscreen launcher window title to org.deepin.ds.launchpad.fullscreen for window manager identification Influence: 1. Verify the fullscreen launcher window title is correctly set to the new identifier 2. Test window manager functionality that depends on window identification 3. Ensure the change does not affect launcher visibility or rendering 4. Check that other window properties remain unchanged feat: 设置全屏启动器窗口标题以便窗管识别 将全屏启动器框架的窗口标题从"Fullscreen Launchpad"改 为"org.deepin.ds.launchpad.fullscreen"。此修改设置了X窗口属性 _NET_WM_NAME为标准化的标识符,使窗口管理器能够轻松区分dde-shell应用程序 窗口与系统中的其他窗口。 Log: 设置全屏启动器窗口标题为org.deepin.ds.launchpad.fullscreen以便窗管 识别 Influence: 1. 验证全屏启动器窗口标题是否正确设置为新标识符 2. 测试依赖于窗口识别的窗口管理器功能 3. 确保此更改不影响启动器的可见性或渲染 4. 检查其他窗口属性是否保持不变
There was a problem hiding this comment.
Sorry @18202781743, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
deepin pr auto review这段代码修改涉及将 以下是针对这段代码的审查意见,包括语法逻辑、代码质量、代码性能和代码安全四个方面: 1. 语法逻辑
2. 代码质量
3. 代码性能
4. 代码安全
总结与建议这是一个积极的代码变更。它将窗口的标识符规范化,使其更符合 Linux 桌面环境的应用开发规范。 建议:
|
Member
|
LGTM |
BLumia
approved these changes
Jan 31, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the window title of the fullscreen launcher frame from
"Fullscreen Launchpad" to "org.deepin.ds.launchpad.fullscreen". This
modification sets the X window property _NET_WM_NAME to a standardized
identifier, allowing window managers to easily distinguish dde-shell
application windows from other windows in the system.
Log: Set fullscreen launcher window title to
org.deepin.ds.launchpad.fullscreen for window manager identification
Influence:
new identifier
identification
feat: 设置全屏启动器窗口标题以便窗管识别
将全屏启动器框架的窗口标题从"Fullscreen Launchpad"改
为"org.deepin.ds.launchpad.fullscreen"。此修改设置了X窗口属性
_NET_WM_NAME为标准化的标识符,使窗口管理器能够轻松区分dde-shell应用程序
窗口与系统中的其他窗口。
Log: 设置全屏启动器窗口标题为org.deepin.ds.launchpad.fullscreen以便窗管
识别
Influence: