chore: update DTK dependency and fix icon display#711
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the DTK QML dependency to a newer libdtk6declarative-dev version and adjusts the icon delegate to preserve aspect ratio when rendering icons, plus refreshes the file copyright years. Flow diagram for icon rendering with PreserveAspectFitflowchart TD
A[IconItemDelegate_loads] --> B[IconImage_component_created]
B --> C[Set_scale_based_on_parent_and_iconScaleFactor]
C --> D[Apply_DTK_icon_palette]
D --> E[Apply_dark_theme_ApplicationHelper_DarkType]
E --> F[Apply_fillMode_Image_PreserveAspectFit]
F --> G[Render_icon_preserving_aspect_ratio]
subgraph Dependency_update_effect
H[debian_control_requires_newer_libdtk6declarative_dev]
H --> I[Build_uses_updated_DTK_QML_features]
I --> B
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In debian/control, using
>> 6.7.33enforces a strict>constraint instead of>=, which may unnecessarily exclude exactly version 6.7.33; consider whether>= 6.7.33better matches the intended minimum supported version.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In debian/control, using `>> 6.7.33` enforces a strict `>` constraint instead of `>=`, which may unnecessarily exclude exactly version 6.7.33; consider whether `>= 6.7.33` better matches the intended minimum supported version.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BLumia, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Updated libdtk6declarative-dev dependency version from >= 6.0.19 to >> 6.7.33 to ensure compatibility with newer DTK features and bug fixes. Added fillMode: Image.PreserveAspectFit to IconImage component in IconItemDelegate.qml to prevent icon distortion and ensure proper aspect ratio preservation when scaling icons. chore: 更新 DTK 依赖并修复图标显示 将 libdtk6declarative-dev 依赖版本从 >= 6.0.19 更新为 >> 6.7.33,以确保 兼容新的 DTK 功能和错误修复。在 IconItemDelegate.qml 的 IconImage 组件中 添加 fillMode: Image.PreserveAspectFit,防止图标变形并确保缩放时保持正确 的宽高比。 PMS: BUG-301329
deepin pr auto review这份代码修改主要涉及两个文件: 1. 文件:
|
Updated libdtk6declarative-dev dependency version from >= 6.0.19 to >> 6.7.33 to ensure compatibility with newer DTK features and bug fixes. Added fillMode: Image.PreserveAspectFit to IconImage component in IconItemDelegate.qml to prevent icon distortion and ensure proper aspect ratio preservation when scaling icons.
chore: 更新 DTK 依赖并修复图标显示
将 libdtk6declarative-dev 依赖版本从 >= 6.0.19 更新为 >> 6.7.33,以确保 兼容新的 DTK 功能和错误修复。在 IconItemDelegate.qml 的 IconImage 组件中 添加 fillMode: Image.PreserveAspectFit,防止图标变形并确保缩放时保持正确 的宽高比。
PMS: BUG-301329
Summary by Sourcery
Update DTK dependency and adjust icon rendering to maintain correct display in the UI.
Bug Fixes:
Build:
Chores: