Skip to content

Commit df0f2ab

Browse files
committed
fix: remove MAC address validator from cloned MAC field
1. Removed the RegularExpressionValidator that enforced MAC address format validation on the cloned-mac-address field 2. This change allows users to input any text value in the cloned MAC address field without format restrictions 3. The validator was likely too restrictive for certain use cases where non-standard MAC address formats might be needed 4. The field still retains its basic functionality but without the format validation constraint Influence: 1. Test entering various text values in the cloned MAC address field including valid MAC addresses, invalid formats, and arbitrary text 2. Verify that all input values are accepted without validation errors 3. Ensure the application doesn't crash when saving non-standard MAC address values 4. Test that the cloned MAC address functionality still works correctly with valid MAC addresses 5. Verify that the UI properly displays whatever value is entered in the field fix: 从克隆MAC地址字段移除MAC地址验证器 1. 移除了对克隆MAC地址字段强制实施MAC地址格式验证的 RegularExpressionValidator 2. 此更改允许用户在克隆MAC地址字段中输入任何文本值,不受格式限制 3. 验证器可能对某些需要非标准MAC地址格式的使用场景过于严格 4. 该字段仍保留其基本功能,但不再有格式验证约束 Influence: 1. 测试在克隆MAC地址字段中输入各种文本值,包括有效的MAC地址、无效格式和 任意文本 2. 验证所有输入值都能被接受,不会出现验证错误 3. 确保应用程序在保存非标准MAC地址值时不会崩溃 4. 测试克隆MAC地址功能在使用有效MAC地址时仍能正常工作 5. 验证UI能正确显示输入到字段中的任何值 PMS: BUG-351321
1 parent 3a921bd commit df0f2ab

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

dcc-network/qml/SectionDNS.qml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// SPDX-FileCopyrightText: 2024 - 2027 UnionTech Software Technology Co., Ltd.
1+
// SPDX-FileCopyrightText: 2024 - 2026 UnionTech Software Technology Co., Ltd.
22
// SPDX-License-Identifier: GPL-3.0-or-later
33
import QtQuick 2.15
44
import QtQuick.Controls 2.15

dcc-network/qml/SectionDevice.qml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -137,9 +137,6 @@ DccTitleObject {
137137
pageType: DccObject.Editor
138138
page: D.LineEdit {
139139
text: root.config.hasOwnProperty("cloned-mac-address") ? root.config["cloned-mac-address"] : ""
140-
validator: RegularExpressionValidator {
141-
regularExpression: NetUtils.macRegExp
142-
}
143140
onTextChanged: {
144141
if (showAlert) {
145142
errorKey = ""

0 commit comments

Comments
 (0)