fix: Remove Qt5 dependencies#321
Conversation
Remove Qt5 dependencies pms: TASK-361721
deepin pr auto review关键摘要:
是否建议立即修改:
|
Reviewer's Guide by SourceryThis pull request migrates the project from Qt5 to Qt6, updates related dependencies such as KF5 to KF6 and introduces Dtk6. It also removes some subdirectories and updates the dde-network-core dependency. Additionally, debian packaging files were removed. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @caixr23 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider updating the project's C++ standard to C++17 or C++20 to leverage more modern language features.
- Since Qt5 is removed, consider removing the compatibility code in
src-old.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: caixr23, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Remove Qt5 dependencies
pms: TASK-361721
Summary by Sourcery
Migrate the project from Qt5 to Qt6 and KF5 to KF6.
Enhancements: