You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix empty translation resources for the dcc-network module by populating network_en.ts and network_en_US.ts with all source strings, enabling the translation platform to detect and translate network UI texts.
Bug Fixes:
Restore missing source strings in dcc-network translation files to ensure the translation platform can detect translation entries.
Enhancements:
Populate network_en.ts and network_en_US.ts with complete network context messages for translation.
This PR populates the previously empty translation files for the dcc-network module by converting the self-closing TS tags into full XML structures containing contexts and message entries with empty translation stubs for all UI strings in both English and English (US).
Entity Relationship Diagram: Structure of Content in Populated .ts Files
erDiagram
TS_Root {
string version
string language
}
ContextElement {
string name "Context Name (e.g., PageAirplane)"
}
MessageElement {
string sourceText "Original UI string"
}
TranslationElement {
string type "(e.g., unfinished)"
string translatedText "(empty or translated string)"
}
TS_Root ||--o{ ContextElement : contains
ContextElement ||--o{ MessageElement : contains
MessageElement ||--|| TranslationElement : has
Loading
File-Level Changes
Change
Details
Files
Expanded TS file into full translation structure
Replaced self-closing tag with opening and closing tags
Inserted multiple sections covering all network UI components
Added entries with text and empty placeholders
dcc-network/translations/network_en.ts
Mirrored full translation structure in US English file
Replaced self-closing tag with opening and closing tags
Duplicated all context and message blocks from network_en.ts
Added blank nodes for each
dcc-network/translations/network_en_US.ts
Tips and commands
Interacting with Sourcery
Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment @sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment @sourcery-ai review to trigger a new review!
The reason will be displayed to describe this comment to others. Learn more.
Hey @BLumia - I've reviewed your changes - here's some feedback:
Instead of hand‐editing these huge TS files, regenerate them with the standard lupdate tool to ensure contexts and messages stay in sync and avoid manual merge conflicts.
Since these are English‐locale TS files, consider populating each with the same text as its (or removing the unfinished flag) so the UI shows English by default rather than blank strings.
Review whether you really need both network_en.ts and network_en_US.ts when their contents are identical—using locale fallback could reduce redundant maintenance.
Here's what I looked at during the review
🟢 General issues: all looks good
🟢 Security: all looks good
🟢 Testing: all looks good
🟢 Complexity: all looks good
🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dcc-network 资源为空,导致翻译平台没有翻译资源,贡献者无法翻译.
Summary by Sourcery
Fix empty translation resources for the dcc-network module by populating network_en.ts and network_en_US.ts with all source strings, enabling the translation platform to detect and translate network UI texts.
Bug Fixes:
Enhancements: