Skip to content

chore: Modify compilation issues#356

Merged
caixr23 merged 1 commit intolinuxdeepin:masterfrom
caixr23:master
Jun 12, 2025
Merged

chore: Modify compilation issues#356
caixr23 merged 1 commit intolinuxdeepin:masterfrom
caixr23:master

Conversation

@caixr23
Copy link
Copy Markdown
Contributor

@caixr23 caixr23 commented Jun 12, 2025

Modify compilation issues

Summary by Sourcery

Fix compilation issues by upgrading the C++ standard to C++14 and enabling pthread support in CMake.

Build:

  • Upgrade C++ standard to C++14 in CMake configuration
  • Enable pthread library initialization and preference flags in CMakeLists.txt

Modify compilation issues
@deepin-ci-robot
Copy link
Copy Markdown

deepin pr auto review

关键摘要:

  • 将C++标准从C++11升级到C++14可能会影响代码的兼容性和性能
  • 添加了对线程库的设置,但未提供上下文说明为什么需要这些设置

是否建议立即修改:

  • 是,需要确保C++标准升级不会引入兼容性问题,并且需要提供添加线程库设置的原因和上下文。

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: caixr23, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Jun 12, 2025

Reviewer's Guide

This PR resolves compilation issues by enhancing CMake threading support with explicit pthread flags and upgrading the project’s C++ standard from 11 to 14.

File-Level Changes

Change Details Files
Enabled pthread support in CMake
  • Added CMAKE_THREAD_LIBS_INIT with -lpthread
  • Set CMAKE_HAVE_THREADS_LIBRARY to 1
  • Enabled CMAKE_USE_PTHREADS_INIT
  • Turned on CMAKE_PREFER_PTHREAD_FLAG
src/CMakeLists.txt
Upgraded C++ standard to C++14
  • Replaced CMAKE_CXX_STANDARD 11 with 14
src/CMakeLists.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@caixr23 caixr23 merged commit 981a20e into linuxdeepin:master Jun 12, 2025
15 of 17 checks passed
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @caixr23 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants