Skip to content

chore: Modify compilation issues#358

Merged
caixr23 merged 1 commit intolinuxdeepin:masterfrom
caixr23:master
Jun 13, 2025
Merged

chore: Modify compilation issues#358
caixr23 merged 1 commit intolinuxdeepin:masterfrom
caixr23:master

Conversation

@caixr23
Copy link
Copy Markdown
Contributor

@caixr23 caixr23 commented Jun 13, 2025

Modify compilation issues

Summary by Sourcery

Build:

  • Conditionally add the 'tests' subdirectory in CMakeLists for Debug build type

Modify compilation issues
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Jun 13, 2025

Reviewer's Guide

The CMake configuration now conditionally includes the test suite only for Debug builds, resolving compilation issues in non-debug modes.

File-Level Changes

Change Details Files
Tests directory is added only for Debug builds
  • Replaced unconditional add_subdirectory("tests")
  • Wrapped add_subdirectory("tests") inside if(CMAKE_BUILD_TYPE STREQUAL "Debug") / endif
  • Adjusted indentation for the new conditional block
CMakeLists.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: caixr23, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caixr23 caixr23 merged commit e1841f0 into linuxdeepin:master Jun 13, 2025
14 checks passed
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @caixr23 - I've reviewed your changes - here's some feedback:

  • Consider using CMake’s built-in BUILD_TESTING (enable_testing()) or a custom option instead of gating tests solely on CMAKE_BUILD_TYPE, which won’t work with multi-config generators.
  • If you need tests in Release/CI builds as well, ensure they aren’t skipped by Debug-only guards—otherwise compilation or regression issues in optimized builds may go unnoticed.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider using CMake’s built-in BUILD_TESTING (enable_testing()) or a custom option instead of gating tests solely on CMAKE_BUILD_TYPE, which won’t work with multi-config generators.
- If you need tests in Release/CI builds as well, ensure they aren’t skipped by Debug-only guards—otherwise compilation or regression issues in optimized builds may go unnoticed.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants