Skip to content

chore: remove reginal variants for es language#363

Merged
caixr23 merged 1 commit intolinuxdeepin:masterfrom
caixr23:master
Jun 23, 2025
Merged

chore: remove reginal variants for es language#363
caixr23 merged 1 commit intolinuxdeepin:masterfrom
caixr23:master

Conversation

@caixr23
Copy link
Copy Markdown
Contributor

@caixr23 caixr23 commented Jun 23, 2025

remove reginal variants for es language

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Jun 23, 2025

Reviewer's Guide

This PR removes the now-unused es_AR (Spanish-Argentina) translation by deleting its translation module file from the codebase.

File-Level Changes

Change Details Files
Removal of es_AR translation support
  • Deleted the entire es_AR translation file
src/translations/dde-network-core_es_AR.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @caixr23 - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

remove reginal variants for es language
@deepin-ci-robot
Copy link
Copy Markdown

deepin pr auto review

根据提供的代码差异,以下是针对删除的翻译文件的一些改进建议:

  1. 翻译完整性

    • 文件 dde-network-core_es_419.tsdde-network-core_es_AR.tsdde-network-core_es_CL.tsdde-network-core_es_MX.ts 中存在大量未完成的翻译(<translation type="unfinished"/>),这可能会导致应用程序在显示这些翻译时出现问题。建议完成这些翻译,或者如果这些翻译不再需要,应该从文件中删除。
  2. 重复代码

    • 所有被删除的文件中包含的翻译内容几乎完全相同,只是语言代码(language)不同。如果这些文件是重复的,应该合并这些文件以减少代码重复。
  3. 翻译质量

    • dde-network-core_es_MX.ts 文件中,Connecting 翻译为 Conectando,这是一个正确的翻译。但是,其他未完成的翻译(如 WEP 40/128-bit KeyWPA/WPA2 Personal 等)需要根据上下文和目标语言进行适当的翻译。
  4. 文件结构

    • 所有被删除的文件都遵循相同的结构,即每个文件包含多个 <context> 元素,每个 <context> 元素包含多个 <message> 元素。这种结构是合理的,但建议在文件顶部添加一些注释,说明这些翻译文件的目的和用途。
  5. 代码维护

    • 如果这些翻译文件是自动生成的,建议检查生成工具的配置,确保生成的文件结构清晰,并且所有翻译都被正确标记为已完成。

综上所述,建议完成所有未完成的翻译,合并重复的文件,并确保所有翻译的质量和准确性。同时,考虑添加一些注释以提高代码的可维护性。

@deepin-ci-robot
Copy link
Copy Markdown

@caixr23: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
deepin-auto-translation 9c3a18e link true /test deepin-auto-translation

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@caixr23 caixr23 changed the title chore: Remove es_AR translation chore: remove reginal variants for es language Jun 23, 2025
@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: caixr23, robertkill

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caixr23 caixr23 merged commit 06ab954 into linuxdeepin:master Jun 23, 2025
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants