Skip to content

fix: SpinBox supports keyboard input #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
caixr23 merged 1 commit into from
Jul 2, 2025
Merged

fix: SpinBox supports keyboard input #365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dcc-network/qml/SectionDevice.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,7 @@ DccTitleObject {
visible: hasMTU
pageType: DccObject.Editor
page: D.SpinBox {
editable: true
value: root.config.hasOwnProperty("mtu") ? root.config.mtu : 0
onValueChanged: {
if (hasMTU && (!root.config.hasOwnProperty("mtu") || root.config.mtu !== value)) {
Expand Down
1 change: 1 addition & 0 deletions dcc-network/qml/SectionIPv6.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,7 @@ DccObject {
displayName: qsTr("Prefix")
pageType: DccObject.Editor
page: D.SpinBox {
editable: true
value: root.addressData.length > index ? root.addressData[index].prefix : 64
from: 0
to: 128
Expand Down
6 changes: 6 additions & 0 deletions dcc-network/qml/SectionVPN.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1458,6 +1458,7 @@ DccTitleObject {
visible: root.dataMap.hasOwnProperty("port")
pageType: DccObject.Editor
page: D.SpinBox {
editable: true
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot Jun 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Consider if all D.SpinBox fields should be editable by default.

Review whether 'editable' should be the default for D.SpinBox to avoid repetitive code and ensure consistency, unless there are valid cases for non-editable instances.

value: root.dataMap.hasOwnProperty(dccObj.name) ? parseInt(root.dataMap[dccObj.name], 10) : 1194
from: 0
to: 65535
Expand Down Expand Up @@ -1496,6 +1497,7 @@ DccTitleObject {
visible: root.dataMap.hasOwnProperty("reneg-seconds")
pageType: DccObject.Editor
page: D.SpinBox {
editable: true
value: root.dataMap.hasOwnProperty(dccObj.name) ? parseInt(root.dataMap[dccObj.name], 10) : 0
from: 0
to: 65535
Expand Down Expand Up @@ -1569,6 +1571,7 @@ DccTitleObject {
visible: root.dataMap.hasOwnProperty("tunnel-mtu")
pageType: DccObject.Editor
page: D.SpinBox {
editable: true
value: root.dataMap.hasOwnProperty(dccObj.name) ? parseInt(root.dataMap[dccObj.name], 10) : 1500
from: 0
to: 65535
Expand Down Expand Up @@ -1607,6 +1610,7 @@ DccTitleObject {
visible: root.dataMap.hasOwnProperty("fragment-size")
pageType: DccObject.Editor
page: D.SpinBox {
editable: true
value: root.dataMap.hasOwnProperty(dccObj.name) ? parseInt(root.dataMap[dccObj.name], 10) : 1300
from: 0
to: 65535
Expand Down Expand Up @@ -1819,6 +1823,7 @@ DccTitleObject {
weight: 80
pageType: DccObject.Editor
page: D.SpinBox {
editable: true
value: root.dataMap.hasOwnProperty(dccObj.name) ? parseInt(root.dataMap[dccObj.name], 10) : 0
from: 0
to: 65535
Expand Down Expand Up @@ -2048,6 +2053,7 @@ DccTitleObject {
visible: root.dataMap["proxy-type"] !== "none"
pageType: DccObject.Editor
page: D.SpinBox {
editable: true
value: root.dataMap.hasOwnProperty(dccObj.name) ? parseInt(root.dataMap[dccObj.name], 10) : 0
from: 0
to: 65535
Expand Down