Skip to content

fix: Duplicate IP addresses do not prompt error messages#366

Merged
robertkill merged 1 commit intolinuxdeepin:masterfrom
robertkill:bug-312367
Jul 1, 2025
Merged

fix: Duplicate IP addresses do not prompt error messages#366
robertkill merged 1 commit intolinuxdeepin:masterfrom
robertkill:bug-312367

Conversation

@robertkill
Copy link
Copy Markdown
Contributor

@robertkill robertkill commented Jun 26, 2025

Add duplicate IP validation and improved error messages for IPv4/IPv6 config 

  • Implement duplicate IP address detection in manual configuration for both IPv4 and IPv6
  • Add specific error messages for different validation failures (invalid IP, netmask, gateway, duplicates)
  • Introduce errorMsg property to store localized error descriptions
  • Update alertText to show context-specific error messages
  • Maintain existing validation checks while enhancing error reporting

pms: BUG-312367

Summary by Sourcery

Enhance manual IP configuration validation by adding duplicate address detection and context-specific error messages for both IPv4 and IPv6

Bug Fixes:

  • Detect and error on duplicate IP addresses in manual IPv4 and IPv6 configurations

Enhancements:

  • Introduce an errorMsg property to hold localized validation messages
  • Add specific error messages for invalid IP, netmask, gateway, and duplicate entries
  • Update alertText bindings to display the relevant errorMsg instead of a static message

Add duplicate IP validation and improved error messages for IPv4/IPv6 config

- Implement duplicate IP address detection in manual configuration for both IPv4 and IPv6
- Add specific error messages for different validation failures (invalid IP, netmask, gateway, duplicates)
- Introduce errorMsg property to store localized error descriptions
- Update alertText to show context-specific error messages
- Maintain existing validation checks while enhancing error reporting

pms: BUG-312367
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Jun 26, 2025

Reviewer's Guide

Enhanced manual IP configuration validation by adding duplicate IP detection and context-specific error messages for both IPv4 and IPv6, while preserving existing checks.

Class diagram for updated SectionIPv4 and SectionIPv6 validation logic

classDiagram
    class SectionIPv4 {
        +string errorKey
        +string errorMsg
        +checkInput()
    }
    class SectionIPv6 {
        +string errorKey
        +string errorMsg
        +checkInput()
    }
    SectionIPv4 : +checkInput() updated to detect duplicate IPs and set errorMsg
    SectionIPv6 : +checkInput() updated to detect duplicate IPs and set errorMsg
    SectionIPv4 --|> DccObject
    SectionIPv6 --|> DccObject
Loading

File-Level Changes

Change Details Files
Enhanced IPv4 manual address validation and error reporting
  • Introduced errorMsg property and cleared it in checkInput
  • Assigned specific errorMsg for invalid IP, netmask, and gateway
  • Implemented duplicate IP detection using a Set
  • Updated alertText to display context-specific errorMsg
dcc-network/qml/SectionIPv4.qml
Enhanced IPv6 manual address validation and error reporting
  • Introduced errorMsg property and cleared it in checkInput
  • Assigned specific errorMsg for invalid IP, netmask, and gateway
  • Implemented duplicate IP detection for IPv6 addresses
  • Updated multiple alertText bindings to display context-specific errorMsg
dcc-network/qml/SectionIPv6.qml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @robertkill - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: caixr23, robertkill

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@robertkill robertkill merged commit 51ff331 into linuxdeepin:master Jul 1, 2025
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants