fix: Duplicate IP addresses do not prompt error messages#366
Merged
robertkill merged 1 commit intolinuxdeepin:masterfrom Jul 1, 2025
Merged
fix: Duplicate IP addresses do not prompt error messages#366robertkill merged 1 commit intolinuxdeepin:masterfrom
robertkill merged 1 commit intolinuxdeepin:masterfrom
Conversation
Add duplicate IP validation and improved error messages for IPv4/IPv6 config - Implement duplicate IP address detection in manual configuration for both IPv4 and IPv6 - Add specific error messages for different validation failures (invalid IP, netmask, gateway, duplicates) - Introduce errorMsg property to store localized error descriptions - Update alertText to show context-specific error messages - Maintain existing validation checks while enhancing error reporting pms: BUG-312367
Reviewer's GuideEnhanced manual IP configuration validation by adding duplicate IP detection and context-specific error messages for both IPv4 and IPv6, while preserving existing checks. Class diagram for updated SectionIPv4 and SectionIPv6 validation logicclassDiagram
class SectionIPv4 {
+string errorKey
+string errorMsg
+checkInput()
}
class SectionIPv6 {
+string errorKey
+string errorMsg
+checkInput()
}
SectionIPv4 : +checkInput() updated to detect duplicate IPs and set errorMsg
SectionIPv6 : +checkInput() updated to detect duplicate IPs and set errorMsg
SectionIPv4 --|> DccObject
SectionIPv6 --|> DccObject
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @robertkill - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
caixr23
approved these changes
Jul 1, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: caixr23, robertkill The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add duplicate IP validation and improved error messages for IPv4/IPv6 config
pms: BUG-312367
Summary by Sourcery
Enhance manual IP configuration validation by adding duplicate address detection and context-specific error messages for both IPv4 and IPv6
Bug Fixes:
Enhancements: