Reviewer's Guide

Refines airplane mode tip visibility logic to depend on both airplane mode state and actual wireless hardware support, by introducing a reusable wireless-support check and reusing it from existing airplane mode support logic.

Sequence diagram for airplane mode tips visibility update

sequenceDiagram
    actor User
    participant NetManager
    participant NetManagerPrivate
    participant NetManagerThreadPrivate
    participant NetworkManager
    participant UI

    User->>NetManager: toggleAirplaneMode(bool enabled)
    NetManager->>NetManagerPrivate: updateAirplaneMode(bool enabled)

    NetManagerPrivate->>NetManagerPrivate: set m_airplaneMode
    NetManagerPrivate->>NetManager: airplaneModeChanged(m_airplaneMode)

    NetManagerPrivate->>NetManagerThreadPrivate: supportWireless()
    NetManagerThreadPrivate->>NetworkManager: networkInterfaces()
    NetworkManager-->>NetManagerThreadPrivate: NetworkManagerDeviceList
    loop check_wifi_devices
        NetManagerThreadPrivate->>NetManagerThreadPrivate: find managed wifi device
    end
    NetManagerThreadPrivate-->>NetManagerPrivate: bool wirelessSupported

    NetManagerPrivate->>UI: updateItemVisible(NetAirplaneModeTipsItem, enabled && wirelessSupported)
    NetManagerPrivate->>UI: updateItemVisible(NetWirelessDisabledItem, false) [if enabled]
    NetManagerPrivate->>UI: updateItemVisible(NetWiredDisabledItem, false) [if enabled]

Class diagram for updated airplane mode and wireless support logic

classDiagram
class NetManagerThreadPrivate {
  - bool m_airplaneModeEnabled
  + bool AirplaneModeEnabled() const
  + bool supportWireless() const
  + bool supportAirplaneMode() const
}

class NetManagerPrivate {
  - bool m_airplaneMode
  - NetManagerThreadPrivate* m_managerThread
  + void updateAirplaneMode(bool enabled)
}

NetManagerPrivate --> NetManagerThreadPrivate : uses
NetManagerThreadPrivate ..> NetworkManager : queries
NetManagerThreadPrivate ..> NetworkManagerDevice : iterates_wifi_devices

class NetworkManager {
  + static NetworkManagerDeviceList networkInterfaces()
}

class NetworkManagerDevice {
  + int type()
  + bool managed()
}

class NetworkManagerDeviceList {
}

NetworkManagerDeviceList "*" --> NetworkManagerDevice

File-Level Changes

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment