fix(wallpapercache): use QImageReader scaled decoding to avoid OOM on…

src/plugin-qt/wallpapercache/imageeffectprocessor.cpp

@@ -17,6 +17,7 @@
 #define PIXMIX_OPACITY      90          // Color opacity
 #define PIXMIX_SATURATION   50          // Saturation
 #define PIXMIX_BRIGHTNESS   -60         // Brightness
+#define PIXMIX_MAX_DIM      7680        // 8K UHD long side cap
 
 DGUI_USE_NAMESPACE
 
@@ -67,9 +68,25 @@ ImageEffectProcessor::EffectType ImageEffectProcessor::effectTypeFromString(cons
 
 QImage ImageEffectProcessor::processPixmixEffect(const QString &imagePath)
 {
-    QImage originalImage;
-    if (!originalImage.load(imagePath)) {
-        qWarning() << "Failed to load image:" << imagePath;
+    QImageReader reader(imagePath);
+    if (!reader.canRead()) {
+        qWarning() << "Cannot read image:" << imagePath;
+        return QImage();
+    }
+
+    QSize originalSize = reader.size();
+    if (!originalSize.isEmpty()
+        && (originalSize.width() > PIXMIX_MAX_DIM || originalSize.height() > PIXMIX_MAX_DIM)) {
+        QSize decodeSize = originalSize;
+        decodeSize.scale(PIXMIX_MAX_DIM, PIXMIX_MAX_DIM, Qt::KeepAspectRatio);
+        reader.setScaledSize(decodeSize);
+        qDebug() << "Decoding image at" << decodeSize
+                 << "(original:" << originalSize << ")";
+    }
+
+    QImage originalImage = reader.read();
+    if (originalImage.isNull()) {
+        qWarning() << "Failed to load image:" << imagePath << reader.errorString();
         return QImage();
     }
 

src/plugin-qt/wallpapercache/scaleimagethread.cpp

@@ -7,9 +7,10 @@
 #include <QImage>
 #include <QDebug>
 #include <QFileInfo>
 #include <QDateTime>
 #include <QCoreApplication>
 #include <QCryptographicHash>
+#include <QImageReader>
 
 ScaleImageThread::ScaleImageThread(QObject *parent)
     : QThread(parent)
@@ -142,21 +143,37 @@
 QImage ScaleImageThread::scaleImage(const TaskData &task)
 {
     qDebug() << "scale image info:" << task.originalPath << " targetSize:" << task.targetSize;
-    QImage image;
-    image.load(task.originalPath);
+
+    QImageReader reader(task.originalPath);
+    if (!reader.canRead()) {
+        qWarning() << "Cannot read image:" << task.originalPath;
+        return QImage();
+    }
+
+    QSize originalSize = reader.size();
+    if (originalSize.isEmpty()) {
+        qWarning() << "Cannot get image size:" << task.originalPath;
+        return QImage();
+    }
+
+    QSize decodeSize = originalSize;
+    decodeSize.scale(task.targetSize, Qt::KeepAspectRatioByExpanding);
+    reader.setScaledSize(decodeSize);
+
+    QImage image = reader.read();
     if (image.isNull()) {
-        qWarning() << "load image failed:" << task.originalPath;
+        qWarning() << "load image failed:" << task.originalPath << reader.errorString();
         return image;
     }
 
-    QSize size = task.targetSize;
-    image = image.scaled(size, Qt::KeepAspectRatioByExpanding, Qt::FastTransformation);
-    image = image.copy(QRect((image.width() - size.width()) / 2,
-                             (image.height() - size.height()) / 2,
-                             size.width(),
-                             size.height()));
-
-    return image;
+    const QSize &size = task.targetSize;
+    if (image.width() < size.width() || image.height() < size.height()) {
+        return image;
+    }
+    return image.copy(QRect((image.width() - size.width()) / 2,
+                            (image.height() - size.height()) / 2,
+                            size.width(),
+                            size.height()));
 }
 
 QString ScaleImageThread::cacheImageToDisk(QImage &image, const TaskData &task, const QString &md5String)

src/plugin-qt/wallpapercache/wallpapercacheservice.cpp

@@ -201,10 +201,14 @@ QString WallpaperCacheService::saveImageFromFd(const QDBusUnixFileDescriptor &fd
     }
     originFile.close();
 
-    // Detect format and rename with extension
-    QImageReader reader(originPath);
-    QString format = reader.format();
-    QString destinationPath = originPath + QString(".%1").arg(format);
+    // Detect format using static method to avoid loading entire image
+    QByteArray format = QImageReader::imageFormat(originPath);
+    if (format.isEmpty()) {
+        qWarning() << "Failed to detect image format:" << originPath;
+        QFile::remove(originPath);
+        return QString();
+    }
+    QString destinationPath = originPath + QString(".%1").arg(QString::fromLatin1(format));
     QFile file(originPath);
     if (!file.rename(destinationPath)) {
         qWarning() << "originPath rename failed";