Skip to content

Commit 5406d0a

Browse files
committed
fix: don't hardcode modules dir
Log: Use variable instead of hardcode for modules dir
1 parent 38dbc44 commit 5406d0a

7 files changed

Lines changed: 18 additions & 6 deletions

File tree

CMakeLists.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ set(SECURITY_COMPILE, "-fstack-protector-all -fPIC")
1515
set(CMAKE_CXX_FLAGS, "${CMAKE_CXX_FLAGS} ${SECURITY_COMPILE}")
1616
set(CMAKE_C_FLAGS, "${CMAKE_C_FLAGS} ${SECURITY_COMPILE}")
1717

18+
add_definitions(-DCMAKE_INSTALL_FULL_LIBDIR=\"${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR}\")
19+
1820
# coverage option
1921
# cmake -DENABLE_COVERAGE=ON ..
2022
OPTION (ENABLE_COVERAGE "Use gcov" OFF)

modules/examples/login/CMakeLists.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,12 @@ link_libraries(
88

99
set(LIB_NAME login)
1010

11+
set(MODULESDIR ${CMAKE_INSTALL_LIBDIR}/dde-session-shell/modules)
12+
1113
aux_source_directory(. SRCS)
1214

1315
# add_library(${LIB_NAME} STATIC ${SRCS})
1416

1517
add_library(${LIB_NAME} SHARED ${SRCS})
1618

17-
install(TARGETS ${LIB_NAME} LIBRARY DESTINATION lib/dde-session-shell/modules)
19+
install(TARGETS ${LIB_NAME} LIBRARY DESTINATION ${MODULESDIR})

modules/examples/network/CMakeLists.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,12 @@ link_libraries(
88

99
set(LIB_NAME network)
1010

11+
set(MODULESDIR ${CMAKE_INSTALL_LIBDIR}/dde-session-shell/modules)
12+
1113
aux_source_directory(. SRCS)
1214

1315
# add_library(${LIB_NAME} STATIC ${SRCS})
1416

1517
add_library(${LIB_NAME} SHARED ${SRCS})
1618

17-
install(TARGETS ${LIB_NAME} LIBRARY DESTINATION lib/dde-session-shell/modules)
19+
install(TARGETS ${LIB_NAME} LIBRARY DESTINATION ${MODULESDIR})

modules/examples/webview/CMakeLists.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ link_libraries(
1111

1212
set(LIB_NAME webview)
1313

14+
set(MODULESDIR ${CMAKE_INSTALL_LIBDIR}/dde-session-shell/modules)
15+
1416
aux_source_directory(. SRCS)
1517

1618
# add_library(${LIB_NAME} STATIC ${SRCS})
@@ -22,4 +24,4 @@ target_link_libraries(${LIB_NAME} PRIVATE
2224
Qt${QT_VERSION_MAJOR}::WebEngineWidgets
2325
)
2426

25-
install(TARGETS ${LIB_NAME} LIBRARY DESTINATION lib/dde-session-shell/modules)
27+
install(TARGETS ${LIB_NAME} LIBRARY DESTINATION ${MODULESDIR})

modules/login/CMakeLists.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ link_libraries(
1414

1515
set(LIB_NAME login)
1616

17+
set(MODULESDIR ${CMAKE_INSTALL_LIBDIR}/dde-session-shell/modules)
18+
1719
aux_source_directory(. SRCS)
1820

1921
# add_library(${LIB_NAME} STATIC ${SRCS})
@@ -22,4 +24,4 @@ add_library(${LIB_NAME} SHARED ${SRCS})
2224

2325
set(LIBRARY_OUTPUT_PATH ${PROJECT_BINARY_DIR}/modules)
2426

25-
install(TARGETS ${LIB_NAME} LIBRARY DESTINATION lib/dde-session-shell/modules)
27+
install(TARGETS ${LIB_NAME} LIBRARY DESTINATION ${MODULESDIR})

modules/virtualkeyboard/CMakeLists.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,12 @@ link_libraries(
88

99
set(LIB_NAME virtualkeyboard)
1010

11+
set(MODULESDIR ${CMAKE_INSTALL_LIBDIR}/dde-session-shell/modules)
12+
1113
aux_source_directory(. SRCS)
1214

1315
add_library(${LIB_NAME} SHARED ${SRCS})
1416

1517
set(LIBRARY_OUTPUT_PATH ${PROJECT_BINARY_DIR}/modules)
1618

17-
install(TARGETS ${LIB_NAME} LIBRARY DESTINATION lib/dde-session-shell/modules)
19+
install(TARGETS ${LIB_NAME} LIBRARY DESTINATION ${MODULESDIR})

src/global_util/modules_loader.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
namespace dss {
1616
namespace module {
1717

18-
const QString ModulesDir = "/usr/lib/dde-session-shell/modules";
18+
const QString ModulesDir = QString("%1/dde-session-shell/modules"),arg(CMAKE_INSTALL_FULL_LIBDIR);
1919
ModulesLoader::ModulesLoader(QObject *parent)
2020
: QThread(parent)
2121
{

0 commit comments

Comments
 (0)