fix: add hardening compiler flags in debian/rules#434
Merged
Conversation
1. Added DEB_CFLAGS_MAINT_APPEND with -Wall for C compiler warnings 2. Added DEB_CXXFLAGS_MAINT_APPEND with -Wall for C++ compiler warnings 3. Added DEB_LDFLAGS_MAINT_APPEND with multiple security hardening flags: - --as-needed for linker optimization - -z relro for RELRO protection - -z now for immediate binding - -z noexecstack for non-executable stacks - -E for exporting symbols 4. These changes improve security and code quality by enabling additional warnings and linker protections fix: 在 debian/rules 中添加编译器加固标志 1. 为 C 编译器添加 DEB_CFLAGS_MAINT_APPEND 并启用 -Wall 警告 2. 为 C++ 编译器添加 DEB_CXXFLAGS_MAINT_APPEND 并启用 -Wall 警告 3. 为链接器添加 DEB_LDFLAGS_MAINT_APPEND 包含多个安全加固标志: - --as-needed 用于链接器优化 - -z relro 用于 RELRO 保护 - -z now 用于立即绑定 - -z noexecstack 用于非可执行栈 - -E 用于导出符号 4. 这些更改通过启用额外的警告和链接器保护来提高安全性和代码质量
Reviewer's GuideExtended debian/rules to append -Wall to C/C++ warnings and apply linker hardening flags (--as-needed, -z relro, -z now, -z noexecstack, -E) for improved security and code quality. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
deepin pr auto review在提供的 代码质量
代码性能
代码安全性
代码维护
建议
总体来说,这些更改有助于提高代码的质量、性能和安全性,是一个积极的改进。 |
18202781743
approved these changes
Jul 3, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: 在 debian/rules 中添加编译器加固标志
Summary by Sourcery
Enable additional compiler warnings and linker hardening flags in debian packaging to improve security and code quality
Build: