sync: from linuxdeepin/dde-session-shell

[deepin-ci-robot]

Synchronize source files from linuxdeepin/dde-session-shell.

Source-pull-request: linuxdeepin/dde-session-shell#28

Summary by Sourcery

Sync source files from linuxdeepin/dde-session-shell and update CMake installation rules for greeter executables

Build:

• switch install(FILES) to install(PROGRAMS) for deepin-greeter in CMakeLists to preserve executable permissions

Chores:

• synchronize source files from linuxdeepin/dde-session-shell upstream

[sourcery-ai]

Reviewer's Guide

This PR syncs source files from the linuxdeepin/dde-session-shell repository and adjusts CMake install directives to correctly treat deepin-greeter as an executable.

File-Level Changes

Change	Details	Files
Updated CMake install directives for deepin-greeter	Replaced install(FILES) with install(PROGRAMS) in the DISABLE_DSS_SNIPE block Replaced install(FILES) with install(PROGRAMS) in the snipe (else) block	CMakeLists.txt
Synchronized upstream configuration and resource files	Updated configs/org.deepin.dde.lock.json from upstream Updated files/wayland/lightdm-deepin-greeter-wayland from upstream	configs/org.deepin.dde.lock.json files/wayland/lightdm-deepin-greeter-wayland

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @deepin-ci-robot - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deepin-ci-robot]

deepin pr auto review

代码审查意见：

CMakeLists.txt

1. 安装目标类型：

   • 在 install(PROGRAMS files/deepin-greeter DESTINATION ${CMAKE_INSTALL_BINDIR}) 和 install(PROGRAMS files/snipe/deepin-greeter DESTINATION ${CMAKE_INSTALL_BINDIR}) 中，PROGRAMS 类型用于可执行文件，而 FILES 类型用于普通文件。确保 deepin-greeter 是一个可执行文件，如果不是，应该使用 FILES 类型。

2. 文件路径：

   • 在 install(FILES files/deepin-debug-config/org.deepin.dde.session-shell.json DESTINATION ${CMAKE_INSTALL_DATADIR}/deepin-debug-config/deepin-debug-config.d) 和 install(FILES files/deepin-log-config/org.deepin.dde.session-shell.json DESTINATION ${CMAKE_INSTALL_DATADIR}/deepin-log-viewer/deepin-log.conf.d) 中，确保文件路径和目标目录是正确的。

configs/org.deepin.dde.lock.json

1. JSON配置文件：
   • 在 configs/org.deepin.dde.lock.json 中，新增的 "WLAN" 应该是一个有效的选项，确认其用途和合法性。

files/wayland/lightdm-deepin-greeter-wayland

1. Shell脚本改进：

   • dbus_values_get_strings 和 dbus_values_get_bool 函数中的正则表达式和 grep 命令可能需要更严格的错误处理，以防止输入格式不符合预期时脚本崩溃。
   • device_handle 函数中，dbus-send 命令的输出被直接传递给 dbus_values_get_bool，如果 dbus-send 命令失败，可能会导致 dbus_values_get_bool 报错。建议添加错误检查。
   • dbus_devices 变量可能需要处理空值或错误输出，以防止后续处理出错。
   • device_path 变量在循环中使用，确保路径拼接正确且安全。

2. 代码可读性：

   • 脚本中添加了注释，有助于理解代码逻辑，但建议保持注释简洁明了，避免过多的解释性注释。

3. 安全性：

   • 脚本中直接使用 dbus-send 命令，确保这些命令的执行不会导致安全风险，例如命令注入。如果可能，应该使用更安全的方法来处理这些命令。

总体来说，代码改动看起来是合理的，但需要确保所有路径和文件类型的使用都是正确的，并且脚本在处理错误和异常情况时更加健壮。

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot, yixinshark

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment