sync: from linuxdeepin/dde-session-shell#457
Merged
Merged
Conversation
There was a problem hiding this comment.
Sorry @deepin-ci-robot, your pull request is too large to review
yixinshark
approved these changes
Sep 12, 2025
Contributor
Author
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deepin-ci-robot, yixinshark The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
/forcemerge |
|
This pr force merged! (status: unstable) |
Synchronize source files from linuxdeepin/dde-session-shell. Source-pull-request: linuxdeepin/dde-session-shell#35
c57285a to
cb266f4
Compare
Contributor
Author
deepin pr auto review这段代码是CMake构建系统的一部分,用于管理插件目录下的子项目。我来分析一下这段代码:
改进建议:
add_subdirectory(login-gesture)
if (DISABLE_DSS_SNIPE)
add_subdirectory(one-key-login)
# 仅在禁用DSS_SNIPE时添加手势登录功能
add_subdirectory(login-gesture)
endif()
# 以下子目录被暂时禁用
# examples: 示例代码,暂不需要构建
# assist_login: 辅助登录功能,暂不需要构建这些建议主要是为了提高代码的可读性和可维护性,使其他开发者更容易理解这段代码的意图和背景。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synchronize source files from linuxdeepin/dde-session-shell.
Source-pull-request: linuxdeepin/dde-session-shell#35