chore: remove startdde dependency

[fly602]

remove startdde dependency

Log: remove startdde dependency
pms: TASK-374777

Summary by Sourcery

Chores:

• Remove references to dde-display.service from systemd configuration files

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request removes the startdde dependency by removing the dde-display.service and associated configurations. The changes involve removing the service definition file, updating the CMakeLists.txt file to remove the service from the list of files to be installed, and removing the symlink installation.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Removed the dde-display.service dependency.	Removed dde-display.service from DDE_SESSION_PRE_WANTS in CMakeLists.txt. Removed the installation of dde-display.service symlink in CMakeLists.txt. Removed the dde-display.service file.	systemd/CMakeLists.txt systemd/dde-session-pre.target.wants/dde-display.service

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[deepin-ci-robot]

deepin pr auto review

代码审查意见：

1. 依赖项更新：

   • 在debian/control文件中，将startdde依赖项更新为dde-daemon，需要确认dde-daemon是否提供了startdde的所有功能，以及是否有兼容性问题。

2. 服务文件删除：

   • 在systemd/CMakeLists.txt文件中，删除了dde-display.service的安装和链接，需要确认这一改动是否与业务逻辑相符，以及是否有其他服务依赖于dde-display.service。

3. 服务文件删除：

   • 在systemd/dde-session-pre.target.wants/dde-display.service文件中，整个文件被删除，需要确认这一改动是否已经过充分讨论和测试，以确保不会影响现有功能。

4. 代码注释：

   • 在systemd/CMakeLists.txt文件中，dde-session-initialized.target.wants部分有一个TODO注释，建议在后续开发中处理，并确保相关服务正确配置。

5. 依赖项版本：

   • 在debian/control文件中，sed的版本要求从>= 4更新到>= 5，需要确认新版本是否满足项目需求，并测试新版本是否与现有代码兼容。

6. 服务启动条件：

   • 在dde-display.service文件中，ExecCondition使用了/bin/sh -c 'test "$DISPLAY" != "" || exit 2'，建议使用更现代的shell语法，如[ -z "$DISPLAY" ] && exit 2，以提高可读性和兼容性。

7. 服务超时设置：

   • 在dde-display.service文件中，TimeoutStartSec设置为infinity，这可能意味着服务没有启动超时限制。需要确认这是否符合业务需求，并考虑是否有必要设置一个合理的超时时间。

8. 服务重启策略：

   • 在dde-display.service文件中，Restart设置为on-failure，RestartSec设置为1s，这是一个合理的重启策略。需要确认是否有必要调整这些设置，以及是否有必要添加日志记录以帮助诊断重启原因。

总体来说，这些改动看起来是为了更新依赖项和服务配置，但需要确保这些改动不会引入新的问题，并且已经过充分的测试和验证。

[sourcery-ai]

Hey @fly602 - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider if the removal of dde-display.service requires corresponding changes in any dependent services or configurations.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fly602, yixinshark

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment