Skip to content

fix: reorder login sound playback in sessionmanager#130

Merged
fly602 merged 1 commit into
linuxdeepin:masterfrom
wyu71:master
Apr 17, 2025
Merged

fix: reorder login sound playback in sessionmanager#130
fly602 merged 1 commit into
linuxdeepin:masterfrom
wyu71:master

Conversation

@wyu71
Copy link
Copy Markdown
Contributor

@wyu71 wyu71 commented Apr 17, 2025 •
edited by sourcery-ai Bot
Loading

  • Move login sound playback logic to the correct position
  • Ensure sound plays only when conditions are met
  • Simplify canPlayEvent checks for better readability

Log: reorder login sound playback in sessionmanager
pms: BUG-309243

Summary by Sourcery

Reorder and improve login sound playback logic in the session manager to ensure correct sound event handling

Bug Fixes:

  • Fix the positioning of login sound playback to ensure it occurs at the correct time during session initialization

Enhancements:

  • Simplify the DBus interface check for sound event playback
  • Improve error handling and validation of sound event conditions

@wyu71
fix: reorder login sound playback in sessionmanager
f61d410 
- Move login sound playback logic to the correct position
- Ensure sound plays only when conditions are met
- Simplify canPlayEvent checks for better readability

Log: reorder login sound playback in sessionmanager
pms: BUG-309243
@deepin-ci-robot
Copy link
Copy Markdown

deepin-ci-robot commented Apr 17, 2025

deepin pr auto review

关键摘要:

  • 移除了登录提示音的播放代码，但未提供替代逻辑或说明原因
  • canPlayEvent 函数中，将返回类型从 bool 改为 QDBusReply<QDBusVariant> 可能会影响调用该函数的其他代码
  • 在 canPlayEvent 函数中，如果 QDBusReply 无效，应该有错误处理逻辑，而不是直接返回 false

是否建议立即修改:

  • 是

sourcery-ai[bot]
sourcery-ai Bot reviewed Apr 17, 2025
View reviewed changes
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @wyu71 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a comment explaining why the login sound playback was reordered.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Apr 17, 2025

Reviewer's Guide by Sourcery

This pull request reorders the login sound playback logic in SessionManager to ensure the sound is played only when the conditions are met. It also simplifies the canPlayEvent checks for improved readability.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Reordered the login sound playback logic to ensure it plays only when the necessary conditions are met.
  • Moved the playLoginSound() call, which was previously located after handleOSSignal(), to after the appearanceConfig initialization.
  • Modified canPlayEvent to directly convert the QDBusVariant to a QVariant and then to a boolean for a more straightforward check.
 src/dde-session/impl/sessionmanager.cpp
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link
Copy Markdown

deepin-ci-robot commented Apr 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fly602, wyu71

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fly602 fly602 merged commit 71b6213 into linuxdeepin:master Apr 17, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@fly602 fly602 fly602 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wyu71 @deepin-ci-robot @fly602