fix: cannot receive ActiveChanged signal when os was restarted#148
Merged
yixinshark merged 1 commit intolinuxdeepin:masterfrom Jun 23, 2025
Merged
fix: cannot receive ActiveChanged signal when os was restarted#148yixinshark merged 1 commit intolinuxdeepin:masterfrom
yixinshark merged 1 commit intolinuxdeepin:masterfrom
Conversation
When the Active of login1 is changed to false, it will not cause the ActiveChanged signal to send because it is the same as the default value. This is a DTK bug and the default value is not initialized. Log: as title Pms: BUG-321333
Reviewer's GuideAdds manual invocation of the login1 Session Active interface during SessionManager's initConnections to initialize the default value and ensure ActiveChanged fires correctly (workaround for a DTK bug with uninitialized default). File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review关键摘要:
是否建议立即修改:
建议的修改:
|
There was a problem hiding this comment.
Hey @yixinshark - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
18202781743
approved these changes
Jun 23, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, yixinshark The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the Active of login1 is changed to false,
it will not cause the ActiveChanged signal to send because it is the same as the default value.
This is a DTK bug and the default value is not initialized.
Log: as title
Pms: BUG-321333
Summary by Sourcery
Bug Fixes: